Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http.url based Sampler #65

Closed
iNikem opened this issue Aug 4, 2021 · 0 comments · Fixed by #70
Closed

http.url based Sampler #65

iNikem opened this issue Aug 4, 2021 · 0 comments · Fixed by #70

Comments

@iNikem
Copy link
Contributor

iNikem commented Aug 4, 2021

There is a request in java instrumentation repo to filter out spans for specific endpoints, such as healthchecks.

There is also a corresponding specification issue.

Before attempting to submit a specification proposal, I would like to try to create a POC sampler in this repository. It would take a list of url patterns and a delegate sampler. Sampler.shouldSample will then check if passed attributes contain http.url semantic attribute. If they do and that url matches one of the patterns, io.opentelemetry.sdk.trace.samplers.SamplingDecision#DROP will be returned. Otherwise, decision will be delegated to the delegate sampler.

At this moment I don't propose nor plan any auto-configuration support for this sampler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant