diff --git a/sdk/trace/provider.go b/sdk/trace/provider.go index 7c5994aada6..ae210f33dad 100644 --- a/sdk/trace/provider.go +++ b/sdk/trace/provider.go @@ -65,7 +65,7 @@ func NewProvider(opts ...ProviderOption) (*Provider, error) { namedTracer: make(map[string]*tracer), } tp.config.Store(&Config{ - DefaultSampler: ProbabilitySampler(defaultSamplingProbability), + DefaultSampler: AlwaysSample(), IDGenerator: defIDGenerator(), MaxAttributesPerSpan: DefaultMaxAttributesPerSpan, MaxEventsPerSpan: DefaultMaxEventsPerSpan, diff --git a/sdk/trace/sampling.go b/sdk/trace/sampling.go index 4f91d4d95c6..20fcfedba5e 100644 --- a/sdk/trace/sampling.go +++ b/sdk/trace/sampling.go @@ -20,8 +20,6 @@ import ( "go.opentelemetry.io/otel/api/core" ) -const defaultSamplingProbability = 1e-4 - // Sampler decides whether a trace should be sampled and exported. type Sampler func(SamplingParameters) SamplingDecision diff --git a/sdk/trace/trace_test.go b/sdk/trace/trace_test.go index 4e9647606dd..22d0950f682 100644 --- a/sdk/trace/trace_test.go +++ b/sdk/trace/trace_test.go @@ -128,12 +128,12 @@ func TestSetName(t *testing.T) { } } -func TestRecordingIsOff(t *testing.T) { +func TestRecordingIsOn(t *testing.T) { tp, _ := NewProvider() - _, span := tp.Tracer("Recording off").Start(context.Background(), "StartSpan") + _, span := tp.Tracer("Recording on").Start(context.Background(), "StartSpan") defer span.End() - if span.IsRecording() == true { - t.Error("new span is recording events") + if span.IsRecording() == false { + t.Error("new span is not recording events") } } @@ -218,7 +218,7 @@ func TestStartSpanWithParent(t *testing.T) { sc1 := core.SpanContext{ TraceID: tid, SpanID: sid, - TraceFlags: 0x0, + TraceFlags: 0x1, } _, s1 := tr.Start(apitrace.ContextWithRemoteSpanContext(ctx, sc1), "span1-unsampled-parent1") if err := checkChild(sc1, s1); err != nil {