Update provider to use AlwaysSampler instead of ProbabilitySampler #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGoldsmith
requested review from
iredelmeier,
jmacd,
krnowak,
lizthegrey,
paivagustavo,
rghetia and
tedsuo
as code owners
krnowak
suggested changes
Mar 3, 2020
|
Not sure why default is AlwaysOn sampler in the spec. It should be the probability sampler. |
|
AlwaysOn seems good to me, and it is what the specification states. |
jmacd
approved these changes
Mar 3, 2020
|
@krnowak removed the cosnt as requested. |
|
Looking into test failures. |
|
@krnowak fixed the tests, this is ready for review. |
paivagustavo
approved these changes
Mar 4, 2020
MrAlias
approved these changes
Mar 4, 2020
krnowak
approved these changes
Mar 5, 2020
MikeGoldsmith
pushed a commit
to MikeGoldsmith/opentelemetry-go
that referenced
this pull request
Mar 13, 2020
…pen-telemetry#506) * update provider to use AlwaysSampler instead of ProbabilitySampler * remove unused defaultSamplingProbability constant * fix broken tests * update failure message in test * fix test description Co-authored-by: Rahul Patel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #498.