Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new function to exclude span kind 4xx for status code #2339

Conversation

hanyuancheung
Copy link
Member

This resolves: #2296

@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #2339 (e3e4959) into main (3a8372e) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2339   +/-   ##
=====================================
  Coverage   73.3%   73.3%           
=====================================
  Files        174     174           
  Lines      12203   12243   +40     
=====================================
+ Hits        8952    8982   +30     
- Misses      3016    3023    +7     
- Partials     235     238    +3     
Impacted Files Coverage Δ
semconv/v1.4.0/http.go 96.5% <100.0%> (+0.2%) ⬆️
semconv/v1.5.0/http.go 96.5% <100.0%> (+0.2%) ⬆️
semconv/v1.6.1/http.go 96.5% <100.0%> (+0.2%) ⬆️
semconv/v1.7.0/http.go 96.5% <100.0%> (+0.2%) ⬆️
sdk/metric/refcount_mapped.go 80.0% <0.0%> (-20.0%) ⬇️
...s/otlp/otlptrace/internal/connection/connection.go 14.5% <0.0%> (-1.6%) ⬇️
sdk/metric/sdk.go 80.0% <0.0%> (-1.5%) ⬇️
exporters/jaeger/jaeger.go 93.4% <0.0%> (-0.9%) ⬇️
sdk/trace/batch_span_processor.go 84.2% <0.0%> (+1.0%) ⬆️

@hanyuancheung hanyuancheung force-pushed the feature/add_new_function_to_exclude_4xx_status_code branch from 0b7b465 to 57c01ba Compare November 1, 2021 13:36
@hanyuancheung hanyuancheung force-pushed the feature/add_new_function_to_exclude_4xx_status_code branch from 57c01ba to 4fe551a Compare November 1, 2021 13:40
@hanyuancheung
Copy link
Member Author

There's something wrong with the gateway error when uploading to codev. Please help check it. Thx.

semconv/v1.7.0/http.go Outdated Show resolved Hide resolved
@hanyuancheung hanyuancheung force-pushed the feature/add_new_function_to_exclude_4xx_status_code branch from 032bb0d to 45f5baf Compare November 3, 2021 12:13
@hanyuancheung hanyuancheung force-pushed the feature/add_new_function_to_exclude_4xx_status_code branch from 79f35f0 to 5510ef9 Compare November 3, 2021 12:49
@hanyuancheung
Copy link
Member Author

hanyuancheung commented Nov 11, 2021

It seems that this problem that is sporadic in ci/test-race is not related to this PR. Could you please help to merge this PR, and I'll open another one to fix it. Thx. @pellared @jmacd

@hanyuancheung hanyuancheung force-pushed the feature/add_new_function_to_exclude_4xx_status_code branch from 868d06b to 660ab71 Compare November 17, 2021 13:39
@pellared
Copy link
Member

@MrAlias @Aneurysm9 PTAL

CHANGELOG.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't set Span.Status for 4xx http status codes for SERVER spans
5 participants