-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new function to exclude span kind 4xx for status code #2339
Merged
MrAlias
merged 17 commits into
open-telemetry:main
from
hanyuancheung:feature/add_new_function_to_exclude_4xx_status_code
Nov 23, 2021
Merged
add new function to exclude span kind 4xx for status code #2339
MrAlias
merged 17 commits into
open-telemetry:main
from
hanyuancheung:feature/add_new_function_to_exclude_4xx_status_code
Nov 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanyuancheung
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
November 1, 2021 12:56
Codecov Report
@@ Coverage Diff @@
## main #2339 +/- ##
=====================================
Coverage 73.3% 73.3%
=====================================
Files 174 174
Lines 12203 12243 +40
=====================================
+ Hits 8952 8982 +30
- Misses 3016 3023 +7
- Partials 235 238 +3
|
hanyuancheung
force-pushed
the
feature/add_new_function_to_exclude_4xx_status_code
branch
from
November 1, 2021 13:36
0b7b465
to
57c01ba
Compare
hanyuancheung
force-pushed
the
feature/add_new_function_to_exclude_4xx_status_code
branch
from
November 1, 2021 13:40
57c01ba
to
4fe551a
Compare
There's something wrong with the gateway error when uploading to codev. Please help check it. Thx. |
pellared
reviewed
Nov 3, 2021
…y-go into feature/add_new_function_to_exclude_4xx_status_code
hanyuancheung
force-pushed
the
feature/add_new_function_to_exclude_4xx_status_code
branch
from
November 3, 2021 12:13
032bb0d
to
45f5baf
Compare
hanyuancheung
force-pushed
the
feature/add_new_function_to_exclude_4xx_status_code
branch
from
November 3, 2021 12:49
79f35f0
to
5510ef9
Compare
jmacd
approved these changes
Nov 5, 2021
pellared
approved these changes
Nov 6, 2021
evantorrie
reviewed
Nov 11, 2021
hanyuancheung
force-pushed
the
feature/add_new_function_to_exclude_4xx_status_code
branch
from
November 17, 2021 13:39
868d06b
to
660ab71
Compare
@MrAlias @Aneurysm9 PTAL |
evantorrie
approved these changes
Nov 23, 2021
MrAlias
reviewed
Nov 23, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves: #2296