Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GetDescriptor method from SDK #570

Closed
MrAlias opened this issue Mar 19, 2020 · 0 comments · Fixed by #575
Closed

Remove GetDescriptor method from SDK #570

MrAlias opened this issue Mar 19, 2020 · 0 comments · Fixed by #575
Labels
area:metrics Part of OpenTelemetry Metrics good first issue Good for newcomers pkg:SDK Related to an SDK package

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Mar 19, 2020

This method was added to accommodate local testing, but is an exported method accessible outside of the package. Returning access to the underlying descriptor, an object we hope to treat as immutable, is not something we want to do.

The internal testing (AFAIK the stress test is the only test that relies on this) need to be integrated into the package so they can access the descriptor directly or use an unexported method.

Originating from comment posted by @MrAlias in https://github.com/_render_node/MDIzOlB1bGxSZXF1ZXN0UmV2aWV3VGhyZWFkMjQ0NjUzMjkwOnYy/pull_request_review_threads/discussion

@MrAlias MrAlias added good first issue Good for newcomers pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics labels Mar 19, 2020
@MrAlias MrAlias added this to the Alpha v0.4 milestone Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics good first issue Good for newcomers pkg:SDK Related to an SDK package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant