Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenCensus bridge: Support AddLink after it is supported by the API #5113

Closed
dashpole opened this issue Mar 27, 2024 · 0 comments · Fixed by #5116
Closed

OpenCensus bridge: Support AddLink after it is supported by the API #5113

dashpole opened this issue Mar 27, 2024 · 0 comments · Fixed by #5116
Assignees
Labels
enhancement New feature or request pkg:bridges Related to a bridge package
Milestone

Comments

@dashpole
Copy link
Contributor

Problem Statement

The OpenCensus bridge currently drops links:

// AddLink adds a link to this span.
func (s *Span) AddLink(l octrace.Link) {
Handle(fmt.Errorf("ignoring OpenCensus link %+v for span %q because OpenTelemetry doesn't support setting links after creation", l, s.String()))
}

Proposed Solution

After #5032 is merged, we can implement support for AddLink by translating the OpenCensus link to an OpenTelemetry link, and using the new AddLink method.

@dashpole dashpole added enhancement New feature or request pkg:bridges Related to a bridge package labels Mar 27, 2024
@dashpole dashpole self-assigned this Mar 28, 2024
@MrAlias MrAlias added this to the v1.25.0 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pkg:bridges Related to a bridge package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants