Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics SDK: Support for aggregation by distributed correlation context (Spec) #383

Closed
jmacd opened this issue Dec 12, 2019 · 0 comments
Closed
Labels
area:metrics Part of OpenTelemetry Metrics prototype Feature to prototype a spec-level decision
Milestone

Comments

@jmacd
Copy link
Contributor

jmacd commented Dec 12, 2019

This issue is filed in to Golang repo as it describes work on the Go Metrics SDK, although the outcome of this work will be a recommendation for how to implement the default SDK for metrics at the OpenTelemetry specification level.

As discussed in open-telemetry/opentelemetry-specification#382, we are interested in having a way to configure metrics export to use aggregation by distributed correlation values. In order to show this, an implementation will be needed. This issue is to define the implementation support needed to perform this kind of aggregation.

This will likely be done as part of an overall configurable metrics Batcher implementation, since much of the work needed for aggregating by distributed correlation is the same as that needed to support configurable metric instruments in general.

Computing the effective aggregate entity is more expensive when using distributed correlations. The design is likely to use the existing Meter implementation to handle bound instruments and direct calling conventions w/o modification--the Batcher is likely to introduce a new Aggregator type that will dispatch as appropriate to other aggregators based on the values of the dynamic variables in the aggregation. This could be done asynchronously, it has been suggested.

This issue should have a partner issue filed to discuss creation of a Batcher implementation that supports configurable aggregations and aggregation label keys (i.e., "views", generally).

@jmacd jmacd added area:metrics Part of OpenTelemetry Metrics prototype Feature to prototype a spec-level decision labels Dec 19, 2019
@rghetia rghetia added this to the Alpha v0.4 milestone Mar 26, 2020
@MrAlias MrAlias modified the milestones: Beta v0.6, Beta v0.7 May 15, 2020
@MrAlias MrAlias modified the milestones: Next, RC1 Sep 30, 2020
hstan referenced this issue in hstan/opentelemetry-go Oct 15, 2020
* Bump cloud.google.com/go from 0.66.0 to 0.67.0 in /detectors/gcp

Bumps [cloud.google.com/go](https://github.com/googleapis/google-cloud-go) from 0.66.0 to 0.67.0.
- [Release notes](https://github.com/googleapis/google-cloud-go/releases)
- [Changelog](https://github.com/googleapis/google-cloud-go/blob/master/CHANGES.md)
- [Commits](googleapis/google-cloud-go@v0.66.0...v0.67.0)

Signed-off-by: dependabot[bot] <[email protected]>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Anthony Mirabella <[email protected]>
@MrAlias MrAlias removed this from the RC1 milestone Feb 12, 2021
@jmacd jmacd closed this as completed Dec 18, 2023
@XSAM XSAM added this to the untracked milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics prototype Feature to prototype a spec-level decision
Projects
Development

No branches or pull requests

4 participants