Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial-success responses for OTLP metrics #3162

Closed
liangyuanpeng opened this issue Sep 10, 2022 · 1 comment · Fixed by #3440
Closed

Partial-success responses for OTLP metrics #3162

liangyuanpeng opened this issue Sep 10, 2022 · 1 comment · Fixed by #3440
Assignees
@MrAlias
Labels
area:metrics Part of OpenTelemetry Metrics enhancement New feature or request pkg:exporter:otlp Related to the OTLP exporter package
Milestone
Metric v0.34.0

Comments

@liangyuanpeng
Copy link

liangyuanpeng commented Sep 10, 2022 •
edited
Loading

Problem Statement

If I understand correctly then we don't support partial-success responses for OTLP metrics yet.
So i create it to trace for partial-success responses of metrics.

Ref:

Remind me if i missed something,Thanks.

/cc @jmacd @MrAlias

Proposed Solution

Alternatives

Prior Art

Additional Context
@liangyuanpeng liangyuanpeng added the enhancement New feature or request label Sep 10, 2022
@liangyuanpeng liangyuanpeng changed the title partial-success responses for OTLP metrics Partial-success responses for OTLP metrics Sep 10, 2022
@jmacd
Copy link
Contributor

jmacd commented Sep 12, 2022

@liangyuanpeng I originally included metrics support in #3106, but it was reverted to avoid conflicts with the new SDK branch. This issue may now stand for following up there, after the grpc/http exporters are fully restored.

@MrAlias MrAlias added area:metrics Part of OpenTelemetry Metrics pkg:exporter:otlp Related to the OTLP exporter package labels Oct 20, 2022
@MrAlias MrAlias moved this to Backlog in Go: Metric SDK (Post-GA) Oct 20, 2022
@MrAlias MrAlias mentioned this issue Nov 2, 2022
Merged
@MrAlias MrAlias self-assigned this Nov 3, 2022
@MrAlias MrAlias moved this to In Progress in Go: Metric SDK (Beta) Nov 3, 2022
@MrAlias MrAlias added this to the Metric v0.34.0 milestone Nov 3, 2022
@MrAlias MrAlias mentioned this issue Nov 3, 2022
Merged
Repository owner moved this from In Progress to Done in Go: Metric SDK (Beta) Nov 9, 2022
@MadVikingGod MadVikingGod mentioned this issue Dec 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrAlias MrAlias

Labels
area:metrics Part of OpenTelemetry Metrics enhancement New feature or request pkg:exporter:otlp Related to the OTLP exporter package
Projects
No open projects
Go: Metric SDK (Beta)
Status: Done
Milestone
Metric v0.34.0
Development

Successfully merging a pull request may close this issue.

Handle partial success response from OTLP server in otlpmetric exporters MrAlias/opentelemetry-go
3 participants
@jmacd @MrAlias @liangyuanpeng