-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "FollowsFrom" relationships #193
Comments
"Reference" may be a misleading term. I thought we called these relationships. I think it will be a set-back if we remove FollowsFrom. |
Use attribute "span.relation" = "childOf" or "followsFrom" in Link. |
I'm confused though, doesn't Is
being replaced with:
which lacks the |
and how does this relate to #225 |
I feel we still have no substitute for "follows from", see here open-telemetry/opentelemetry-specification#337 (comment) |
I chose to do #272 in order to implement Links at span creation time, rather than trying to munge FollowsFrom into a Link etc |
fixed by #451 |
…aws (#193) * Bump github.com/aws/aws-sdk-go from 1.33.19 to 1.33.20 in /detectors/aws Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.33.19 to 1.33.20. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-go@v1.33.19...v1.33.20) Signed-off-by: dependabot[bot] <[email protected]> * Auto-fix go.sum changes in dependent modules Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Reference is not defined in the specs. What does a follow from mean?
Originally posted by @bogdandrutu in #190
Note that this would affect FollowsFrom-based relationships in the OpenTracing bridge.
The text was updated successfully, but these errors were encountered: