Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track specification change for composite TextMapPropagator inject/extract #1696

Closed
MrAlias opened this issue Mar 12, 2021 · 1 comment
Closed

Track specification change for composite TextMapPropagator inject/extract #1696

MrAlias opened this issue Mar 12, 2021 · 1 comment
Labels
area:context Part of OpenTelemetry context blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made
Milestone
RC1

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Mar 12, 2021

Currently the composite TextMapPropagator requires that the inject/extract methods accept a getter/setter as an argument even though the underlying TextMapPropagator is only given the option to support this argument. The implementation of the composite TextMapPropagator does not support these currently required arguments (it is just a TextMapPropagator interface itself).

A PR to the specification has been made to ease this requirement. Until this is merged and released, this implementation of the specification will be out of compliance. This issue is intended to track these needed changes upstream and ensure when we release an RC it is for an implementation of a specification that we can be compliant with.
@MrAlias MrAlias added blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made release:required-for-ga area:context Part of OpenTelemetry context labels Mar 12, 2021
@MrAlias MrAlias added this to the RC1 milestone Mar 12, 2021
@Aneurysm9
Copy link
Member

@MrAlias looks like the spec PR linked here was merged. Can this issue be closed, or is there something we need to do?

@MrAlias MrAlias closed this as completed May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:context Part of OpenTelemetry context blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made
Projects
None yet
Milestone
RC1
Development

No branches or pull requests
2 participants
@Aneurysm9 @MrAlias