feat: increase unittest coverage

open-telemetry · Nov 3, 2021 · 5510ef9 · 5510ef9
1 parent 36c5264
commit 5510ef9
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 16 deletions.
diff --git a/semconv/v1.4.0/http_test.go b/semconv/v1.4.0/http_test.go
@@ -867,10 +867,8 @@ func TestSpanStatusFromHTTPStatusCode(t *testing.T) {
 			assert.Empty(t, msg, "message should not be set if error can be inferred from code")
 		}
 	}
-	code, valid := validateHTTPStatusCode(400)
-	if !valid {
-		assert.Equalf(t, codes.Unset, code, "message should be set if error cannot be inferred from code")
-	}
+	code, _ := SpanStatusFromHTTPStatusCode(400, trace.SpanKindServer)
+	assert.Equalf(t, codes.Unset, code, "message should be set if error cannot be inferred from code")
 }
 
 func getExpectedCodeForHTTPCode(code int, spanKind trace.SpanKind) codes.Code {

diff --git a/semconv/v1.5.0/http_test.go b/semconv/v1.5.0/http_test.go
@@ -867,10 +867,8 @@ func TestSpanStatusFromHTTPStatusCode(t *testing.T) {
 			assert.Empty(t, msg, "message should not be set if error can be inferred from code")
 		}
 	}
-	code, valid := validateHTTPStatusCode(400)
-	if !valid {
-		assert.Equalf(t, codes.Unset, code, "message should be set if error cannot be inferred from code")
-	}
+	code, _ := SpanStatusFromHTTPStatusCode(400, trace.SpanKindServer)
+	assert.Equalf(t, codes.Unset, code, "message should be set if error cannot be inferred from code")
 }
 
 func getExpectedCodeForHTTPCode(code int, spanKind trace.SpanKind) codes.Code {

diff --git a/semconv/v1.6.1/http_test.go b/semconv/v1.6.1/http_test.go
@@ -866,10 +866,8 @@ func TestSpanStatusFromHTTPStatusCode(t *testing.T) {
 			assert.Empty(t, msg, "message should not be set if error can be inferred from code")
 		}
 	}
-	code, valid := validateHTTPStatusCode(400)
-	if !valid {
-		assert.Equalf(t, codes.Unset, code, "message should be set if error cannot be inferred from code")
-	}
+	code, _ := SpanStatusFromHTTPStatusCode(400, trace.SpanKindServer)
+	assert.Equalf(t, codes.Unset, code, "message should be set if error cannot be inferred from code")
 }
 
 func getExpectedCodeForHTTPCode(code int, spanKind trace.SpanKind) codes.Code {

diff --git a/semconv/v1.7.0/http_test.go b/semconv/v1.7.0/http_test.go
@@ -867,10 +867,9 @@ func TestSpanStatusFromHTTPStatusCode(t *testing.T) {
 			assert.Empty(t, msg, "message should not be set if error can be inferred from code")
 		}
 	}
-	code, valid := validateHTTPStatusCode(400)
-	if !valid {
-		assert.Equalf(t, codes.Unset, code, "message should be set if error cannot be inferred from code")
-	}
+	code, _ := SpanStatusFromHTTPStatusCode(400, trace.SpanKindServer)
+	assert.Equalf(t, codes.Unset, code, "message should be set if error cannot be inferred from code")
+
 }
 
 func getExpectedCodeForHTTPCode(code int, spanKind trace.SpanKind) codes.Code {