Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor getGoDetails() to use Go buildinfo package #652

Closed
damemi opened this issue Feb 8, 2024 · 0 comments · Fixed by #653
Closed

Refactor getGoDetails() to use Go buildinfo package #652

damemi opened this issue Feb 8, 2024 · 0 comments · Fixed by #653
Assignees
Milestone

Comments

@damemi
Copy link
Contributor

damemi commented Feb 8, 2024

Looks like that error comes from getGoDetails() when trying to parse the go build info. I think that the go version or build environment is the issue, but it seems like a bug in our code to not handle it.

@edeNFed it looks like a lot of this was copied from the Go buildinfo package, is there any reason not to use that package directly? Wonder if the extra handling they do supports older versions like this but it's a little over my head

Using buildinfo package makes total sense, I don't remember the reason for not using it in the first place.
Also, just noticed go1.22 has a new go/version package we can probably leverage as well.

Originally posted by @edeNFed in #636 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants