Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

otelslog: Handle nil values #6242

Closed
pellared opened this issue Oct 13, 2024 · 0 comments · Fixed by #6246
Closed

otelslog: Handle nil values #6242

pellared opened this issue Oct 13, 2024 · 0 comments · Fixed by #6246
Assignees
@pellared
Labels
bridge: slog Related to the slog bridge bug Something isn't working
Milestone
v1.32.0

Comments

@pellared
Copy link
Member

pellared commented Oct 13, 2024 •
edited
Loading

Most likely otelslog does handle empty values (and nil) properly:

opentelemetry-go-contrib/bridges/otelslog/handler.go

Lines 413 to 414 in c3c8538

case slog.KindAny:
return log.StringValue(fmt.Sprintf("%+v", v.Any()))

@pellared pellared added bug Something isn't working bridge: slog Related to the slog bridge labels Oct 13, 2024
@pellared pellared self-assigned this Oct 13, 2024
@pellared pellared mentioned this issue Oct 14, 2024
Merged
@pellared pellared added this to the v1.32.0 milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pellared pellared

Labels
bridge: slog Related to the slog bridge bug Something isn't working
Projects
None yet
Milestone
v1.32.0
Development

Successfully merging a pull request may close this issue.

otelslog: Transform nil attribute to empty log.Value pellared/opentelemetry-go-contrib
1 participant
@pellared