-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples built with 'golang:alpine' Docker image no longer work #623
Comments
Or maybe rather this might give the right context:
It seems like building with Go < 1.16 resolves the issue 'automatically' and fixes
Whereas with Go 1.16 we are getting an error by default. |
Thanks catching and documenting this!
This sounds like the appropriate resolution. That way we ensure other users that use Go 1.16 will not encounter this error as well. This also motivates me to add 1.16 to the versions we validate in our CI system. |
Instead of batching based on the Resource pointer which is not guaranteed to uniquely identify common Resources, use the `String` method which is. Renames the external test package to be identified as the integration testing. This testing structure (the mock exporter) batches exported resources transmitted from the resource. This is needed as there is no guarantees that a batch will be exported in a single payload, therefore, it is not an ideal place to add resource batch testing for the exporter itself. Add unit tests to ensure the Exporter is correctly batching spans by resource.
It seems that instrumentation examples which are based on the
golang:alpine
image can no longer be brought up withdocker-compose
.Example from
gin-gonic
, which fails with:Since this behavior is not present in examples built with
golang:1.14-alpine
, I presume the issue is related to the fact that thegolang:alpine
is now based on Go 1.16, which introduced some changes to module-aware mode for thego install
command.One possible way to fix this would be to ensure all examples use image version with Go version < 1.16. Otherwise it should be investigated what is the exact cause why Go fails to fetch the mentioned modules and how to mitigate it.
The text was updated successfully, but these errors were encountered: