Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

otelhttp's body wrapper doesn't respect NoBody #2982

Closed
dashpole opened this issue Nov 10, 2022 · 0 comments · Fixed by #2983
Closed

otelhttp's body wrapper doesn't respect NoBody #2982

dashpole opened this issue Nov 10, 2022 · 0 comments · Fixed by #2983
Labels
area: instrumentation Related to an instrumentation package bug Something isn't working instrumentation: otelhttp
Milestone
untracked

Comments

@dashpole
Copy link
Contributor

Upstream k8s issue: kubernetes/kubernetes#113791

Similar to how otelhttp does not wrap the request body when it is nil, it should not wrap the request body when it is set to NoBody, which seems to be the equivalent of nil for the Body.

We should treat NoBody the same as we do nil.
@dashpole dashpole added enhancement New feature or request area: instrumentation Related to an instrumentation package instrumentation: otelhttp bug Something isn't working and removed enhancement New feature or request labels Nov 10, 2022
@dashpole dashpole mentioned this issue Nov 10, 2022
Merged
@dashpole dashpole mentioned this issue Jan 19, 2023
Closed
@pellared pellared added this to the untracked milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: instrumentation Related to an instrumentation package bug Something isn't working instrumentation: otelhttp
Projects
None yet
Milestone
untracked
Development

Successfully merging a pull request may close this issue.

otelhttp: Treat http.NoBody the same as a nil body dashpole/opentelemetry-go-contrib
2 participants
@dashpole @pellared