Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comments for otelgrpc/filters.HealthCheck is incorrect #2674

Closed
10 tasks done
ymotongpoo opened this issue Aug 17, 2022 · 0 comments · Fixed by #2673
Closed
10 tasks done

comments for otelgrpc/filters.HealthCheck is incorrect #2674

ymotongpoo opened this issue Aug 17, 2022 · 0 comments · Fixed by #2673
Labels
area: instrumentation Related to an instrumentation package enhancement New feature or request
Milestone

Comments

@ymotongpoo
Copy link
Contributor

Background

Package Link: go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc/filters

gRPC filters are merged in #2572, but the comments for filters.HealthCheck is not updated correctly as mentioned #2672 (review).

Why can this instrumentation not be included in the package itself?

N/A

Why can this instrumentation not be hosted in a dedicated repository?

N/A

Proposed Solution

Update commments

Tracing

N/A

Metrics

N/A

Prior Art

N/A

Tasks

  • Code complete:
    • Comprehensive unit tests.
    • End-to-end integration tests.
    • Tests all passing.
    • Instrumentation functionality verified.
  • Documented
  • Examples
    • Dockerfile file to build example application.
    • docker-compose.yml to run example in a docker environment to demonstrate instrumentation.
@ymotongpoo ymotongpoo added area: instrumentation Related to an instrumentation package enhancement New feature or request labels Aug 17, 2022
@pellared pellared added this to the untracked milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: instrumentation Related to an instrumentation package enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants