From 853696a085b44c875f14a5d1ff99f60561e19892 Mon Sep 17 00:00:00 2001 From: Bryan Naegele Date: Thu, 5 Sep 2024 19:29:47 -0600 Subject: [PATCH 1/2] Exception should be atom --- apps/opentelemetry_api/lib/open_telemetry/span.ex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/opentelemetry_api/lib/open_telemetry/span.ex b/apps/opentelemetry_api/lib/open_telemetry/span.ex index 089a0146..15d4abec 100644 --- a/apps/opentelemetry_api/lib/open_telemetry/span.ex +++ b/apps/opentelemetry_api/lib/open_telemetry/span.ex @@ -146,7 +146,7 @@ defmodule OpenTelemetry.Span do Exception.format_stacktrace(trace)} ] - add_event(span_ctx, "exception", exception_attributes ++ attributes) + add_event(span_ctx, :exception, exception_attributes ++ attributes) end def record_exception(_, _, _, _), do: false From 1d9c4e597b32502ad2f3d006eb0ccda0cc3a66d5 Mon Sep 17 00:00:00 2001 From: Bryan Naegele Date: Thu, 5 Sep 2024 19:33:55 -0600 Subject: [PATCH 2/2] Update otel_tests.exs --- test/otel_tests.exs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/otel_tests.exs b/test/otel_tests.exs index 786e0f65..677bda51 100644 --- a/test/otel_tests.exs +++ b/test/otel_tests.exs @@ -259,7 +259,7 @@ defmodule OtelTests do :infinity, 0, [ - {:event, _, "exception", ^attributes} + {:event, _, :exception, ^attributes} ] } )}