[bugFix] Meter tags are now recognized as identifiers #5982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pkg:OpenTelemetry
…eter identity uniqueness.
dulikvor
force-pushed
the
users/dulikvor/markinstrumentation
branch
from
2458d0b to
b5d1011
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5982 +/- ##
==========================================
- Coverage 86.11% 86.08% -0.04%
==========================================
Files 257 257
Lines 11690 11693 +3
==========================================
- Hits 10067 10066 -1
- Misses 1623 1627 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
github-actions
bot
added
the
Stale
cijothomas
reviewed
Nov 26, 2024
cijothomas
approved these changes
Nov 26, 2024
github-actions
bot
removed
the
Stale
cijothomas
added
the
spec-compliance
src/OpenTelemetry/CHANGELOG.md
Outdated
| @@ -6,6 +6,10 @@ Notes](../../RELEASENOTES.md). | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| * Updated `OpenTelemetry.Metrics.MetricStreamIdentity` Metric tags are now considered identifiers, | |||
There was a problem hiding this comment.
Suggested change
| * Updated `OpenTelemetry.Metrics.MetricStreamIdentity` Metric tags are now considered identifiers, | |
| * Update Metric tags to be identifying for the Meter, aligning with the specification. Previously, Metric tags were omitted from being identifying. |
There was a problem hiding this comment.
Will anyone reading this understand it? 🤣
How about...
- Meter.Tags will now be considered when resolving the SDK metric to update when measurements are recorded. Meters with the same name and different tags will now lead to unique metrics.
PS: There is a lint error can't merge until that is resolved.
There was a problem hiding this comment.
Fine with the latter, made the change. can linter re instigate, I will check if its yet too long.
rajkumar-rangaraj
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5859
Design discussion issue #
Changes
Metric tags are now considered identifiers, contributing to metric scope uniqueness.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes