Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename metrics exporter option MetricExportInterval to MetricExportIntervalMilliSeconds #2193

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Jul 26, 2021

Addresses the PR comment: #2192 (comment)

Changes

  • Rename the metrics exporter option MetricExportInterval to MetricExportIntervalMilliSeconds for Console, InMemory and OTLP exporter

@utpilla utpilla requested a review from a team July 26, 2021 22:46
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect there would be more renamings, if/when spec gives this parameter a name

@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #2193 (66c86e7) into main (28f59eb) will not change coverage.
The diff coverage is 25.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2193   +/-   ##
=======================================
  Coverage   74.68%   74.68%           
=======================================
  Files         217      217           
  Lines        6948     6948           
=======================================
  Hits         5189     5189           
  Misses       1759     1759           
Impacted Files Coverage Δ
...InMemory/InMemoryExporterMetricHelperExtensions.cs 0.00% <0.00%> (ø)
...metry.Exporter.InMemory/InMemoryExporterOptions.cs 0.00% <0.00%> (ø)
...etryProtocol/OtlpMetricExporterHelperExtensions.cs 0.00% <0.00%> (ø)
...orter.OpenTelemetryProtocol/OtlpExporterOptions.cs 100.00% <100.00%> (ø)
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 97.14% <0.00%> (-2.86%) ⬇️
...ZPages/Implementation/ZPagesExporterEventSource.cs 62.50% <0.00%> (+6.25%) ⬆️

@cijothomas cijothomas merged commit d99db27 into open-telemetry:main Jul 26, 2021
@CodeBlanch
Copy link
Member

Sorry late on this one but I think Milliseconds is more standard than MilliSeconds. In our repo and also dotnet/runtime.

@utpilla utpilla deleted the utpilla/Rename-MetricExportInterval-Option branch July 30, 2021 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants