Add InMemoryExporter for Metrics #2192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2192 +/- ##
==========================================
- Coverage 74.78% 74.69% -0.09%
==========================================
Files 215 217 +2
Lines 6939 6948 +9
==========================================
+ Hits 5189 5190 +1
- Misses 1750 1758 +8
|
cijothomas
reviewed
Jul 26, 2021
cijothomas
approved these changes
Jul 26, 2021
cijothomas
reviewed
Jul 26, 2021
| /// <summary> | ||
| /// Gets or sets the metric export interval. | ||
| /// </summary> | ||
| public int MetricExportInterval { get; set; } = 1000; |
There was a problem hiding this comment.
not this PR, but we'll need to make the units obvious for the time interval! (similar to tracing. eg: ScheduledDelayMilliseconds)
cijothomas
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes