Add observer instrument #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… interface to emit export record.
cijothomas
requested review from
austinlparker,
bruno-garcia,
discostu105,
lmolkova,
MikeGoldsmith and
SergeyKanzhelev
as code owners
MikeGoldsmith
suggested changes
Mar 13, 2020
|
@MikeGoldsmith Addressed comments. Please re-review. |
SergeyKanzhelev
approved these changes
Mar 13, 2020
MikeGoldsmith
approved these changes
Mar 16, 2020
|
@SergeyKanzhelev Please merge. |
Yun-Ting
pushed a commit
to Yun-Ting/opentelemetry-dotnet
that referenced
this pull request
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #531
Observer instruments do not have access to context, and they also don't expose public bound instrument, as metrics are observed via callbacks only.
Observer uses LastValue aggregator.
Additional Note: Observer instrument part is implemented without generics. i.e Int64Observer and DoubleObserver are separate classes.
If all okay, a follow up PR would replace generics for all other instruments as well.