Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[baggage] space encoding in baggage item value when injecting baggage #5260

Open
lachmatt opened this issue Jan 26, 2024 · 2 comments · Fixed by #5303
Open

[baggage] space encoding in baggage item value when injecting baggage #5260

lachmatt opened this issue Jan 26, 2024 · 2 comments · Fixed by #5303
Labels
bug Something isn't working

Comments

@lachmatt
Copy link
Contributor

lachmatt commented Jan 26, 2024 •
edited
Loading

Bug Report

Packages:

OpenTelemetry.Api 1.7.0

Symptom

When injecting baggage, ' ' character (space) in baggage item value is encoded using +, but should be percent-encoded according to the specification.

Reproduce

Issue evident in BaggagePropagatorTests

Additional Context

Similar issue fixed recently by @pellared in open-telemetry/opentelemetry-go#4756
@lachmatt lachmatt added the bug Something isn't working label Jan 26, 2024
@lachmatt lachmatt mentioned this issue Jan 31, 2024
Closed
4 tasks
@reyang
Copy link
Member

reyang commented Jan 31, 2024

Related to #5210.

@lachmatt lachmatt mentioned this issue Feb 1, 2024
Merged
4 tasks
@vishweshbankwar vishweshbankwar mentioned this issue Apr 2, 2024
Open
@lachmatt lachmatt mentioned this issue Jun 12, 2024
Open
@lachmatt
Copy link
Contributor Author

This should be reopened after #5687 was merged.

@Kielek Kielek reopened this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@Kielek @reyang @lachmatt