Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[InMemoryExporter] Throw ObjectDisposedException if Export happened after disposal #3607

Merged
merged 4 commits into from
Aug 26, 2022

Conversation

reyang
Copy link
Member

@reyang reyang commented Aug 26, 2022

Related to #1848 and #3578.

This should help the developers catch the bugs during the development / unit testing.

@reyang reyang requested a review from a team August 26, 2022 03:53
@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #3607 (61dfb7e) into main (4310e08) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3607      +/-   ##
==========================================
+ Coverage   87.12%   87.22%   +0.09%     
==========================================
  Files         277      277              
  Lines        9944     9950       +6     
==========================================
+ Hits         8664     8679      +15     
+ Misses       1280     1271       -9     
Impacted Files Coverage Δ
...etheus.HttpListener/Internal/PrometheusExporter.cs 100.00% <ø> (ø)
...penTelemetry.Exporter.InMemory/InMemoryExporter.cs 94.73% <100.00%> (+2.42%) ⬆️
src/OpenTelemetry/Logs/Pool/LogRecordSharedPool.cs 78.94% <0.00%> (-21.06%) ⬇️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 73.52% <0.00%> (-8.83%) ⬇️
src/OpenTelemetry/BatchExportProcessor.cs 82.24% <0.00%> (-1.87%) ⬇️
...tpListener/Internal/PrometheusCollectionManager.cs 80.48% <0.00%> (+2.43%) ⬆️
...metryProtocol/Implementation/ActivityExtensions.cs 96.15% <0.00%> (+4.39%) ⬆️
...tation/OpenTelemetryProtocolExporterEventSource.cs 85.00% <0.00%> (+10.00%) ⬆️
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 77.27% <0.00%> (+18.18%) ⬆️
...entation/ExportClient/OtlpGrpcTraceExportClient.cs 78.57% <0.00%> (+28.57%) ⬆️
... and 1 more

@reyang
Copy link
Member Author

reyang commented Aug 26, 2022

I thought this would be useful, and it came too fast:

image

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch changed the title Throw ObjectDisposedException if Export happened after disposal [InMemoryExporter] Throw ObjectDisposedException if Export happened after disposal Aug 26, 2022
@CodeBlanch CodeBlanch merged commit 372767a into open-telemetry:main Aug 26, 2022
@reyang reyang deleted the reyang/inmem branch August 26, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants