Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Metric and MetricPoint classes to allow users modify already created metric data in pipelines #3541

Closed
Ilia-work opened this issue Aug 4, 2022 · 7 comments
Labels
enhancement New feature or request Stale Issues and pull requests which have been flagged for closing due to inactivity

Comments

@Ilia-work
Copy link

Hello,

the properties of LogRecord class were made settable to unblock users who want to scrub data or otherwise modify it in their pipelines (#3378).

It would be very useful to have similar possibilities in Metric and MetricPoint classes. For example, set a custom StartTime/EndTime for MetricPoint.

Do you plan to make changes in Metric and MetricPoint classes to allow users modify already created metric data in pipelines?

@Ilia-work Ilia-work added the enhancement New feature or request label Aug 4, 2022
@cijothomas
Copy link
Member

Can you describe a bit more about what is the end goal? Is start/end time the only thing required and why?

@Ilia-work
Copy link
Author

Hello,

A couple of years ago we have built our own diagnostics data collector and now would like to integrate OpenTelemetry into it. Our collector receives json data through REST calls and we would like to adjust our collector to make it possible to convert diagnostics data from our custom format into the OTLP format and then send it to the OTLP collector.

You have already made all properties of LogRecord settable (#3378) which allowed us to create custom LogRecords and it would be very useful to have the same capabilities for Metric/MetricPoint.

The ability to specify Metrics/MetricPoint properties could help us and other users to integrate your solution into existing diagnostic data collectors and could make usage scenarios of the OTLP .NET more flexible.

Thank you in advance.

@cijothomas
Copy link
Member

https://github.com/open-telemetry/opentelemetry-specification/pull/2951/files Some spec work occurring, which might be what you are looking for.

@Ilia-work
Copy link
Author

Hello Cijo, thank you for the answer.

Yes, it looks like that the planned changes can be useful for us.

Currently these changes are only for the specification. Do you have any issue opened or document/roadmap where this feature mentioned and we can track the progress of it in the opentelemetry-dotnet repo?

@goldenc
Copy link

goldenc commented Dec 14, 2022

+1

Copy link
Contributor

This issue was marked stale due to lack of activity and will be closed in 7 days. Commenting will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Sep 25, 2024
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Closed as inactive. Feel free to reopen if this issue is still a concern.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale Issues and pull requests which have been flagged for closing due to inactivity
Projects
None yet
Development

No branches or pull requests

3 participants