Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What should the default MetricReaderType be? #2921

Closed
alanwest opened this issue Feb 18, 2022 · 2 comments
Closed

What should the default MetricReaderType be? #2921

alanwest opened this issue Feb 18, 2022 · 2 comments
Labels
metrics Metrics signal related question Further information is requested
Milestone

Comments

@alanwest
Copy link
Member

Can we settle on a universal default for MetricReaderType (manual vs. periodic), or should the default vary based on the type of exporter used (OTLP, Console, etc)? This question was raised here.

#2717 moved the notion of MetricReaderType to the SDK for configuring whether to use the periodic metric reader or the "manual" one.

Currently, we do not have a universal default. For instance, when using the helper extension methods AddConsoleExporter and AddOtlpExporter the defaults are MetricReaderType.Manual and MetricReaderType.Periodic, respectively.

A prior conversation posed the question of whether the Console exporter should default to MetricReaderType.Periodic.

@alanwest alanwest added the question Further information is requested label Feb 18, 2022
@cijothomas
Copy link
Member

ConsoleExporter spec (https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk_exporters/stdout.md) says it is a push metric exporter, which says it receives metrics from a paired periodic exporting reader, which says metrics are passed based on a user-configurable time interval, with default as 60,000msec... Same for OTLP too.

Unless I mis understood the spec intent..

@cijothomas cijothomas added this to the 1.2.0 milestone Feb 18, 2022
@cijothomas cijothomas added the metrics Metrics signal related label Feb 18, 2022
@cijothomas
Copy link
Member

Closing, as there is no MetricReaderType anymore.
The defaults are covered by spec and being implemented in the SDK/Exporters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metrics Metrics signal related question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants