-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate if OpenTelemetry.AutoInstrumentation
can be loaded from native profiler without the help of StartupHook.
#2295
Comments
See #2286 (comment) In short: not at this time we opted to require the StartupHook for .NET applications. The CLR Profiler won't attach and will log an error if the StartupHook is not configured. |
I have relate problem, with err message: File name: 'Microsoft.Extensions.Logging.Abstractions, Version=7.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60' |
One of the reasons we switched to the startup hook to bootstrap everything is that we noticed that many aspnetcore apps that relied on the profiler to bootstrap everything appeared to bootstrap things too early. We did not see the same problem with the startup hook solution. If we decide to follow this approach, we will need to do additional testing to ensure that we are bootstrapping things at an appropriate time. |
@Kielek can sql call query detected in dotnet auto instrumentation? |
@lumbans, it depends what type of library you are using for it. For v0.6.0 there is a support for SqlClient both from Microsoft.Data.SqlClient and System.Data.SqlClient. Ref: https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/v0.6.0/docs/config.md#traces-instrumentations Could you please rise new issues for each independent topic? It is a lot of easier to manage one topic per issue. |
@rajkumar-rangaraj, please check if current state is enough from your perspective. |
As discussed in SIG, we need to clean-up code in StartupHook as the native layer also uses startuphook to instrument. |
Not related to this PR, need to validate if
OpenTelemetry.AutoInstrumentation
can be loaded from native profiler without the help of StartupHook.Originally posted by @rajkumar-rangaraj in #2286 (comment)
The text was updated successfully, but these errors were encountered: