From fb2462fba57348b448e436322bcd553b8fbdf24b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20Neum=C3=BCller?= Date: Wed, 17 Aug 2022 17:41:11 +0200 Subject: [PATCH 1/8] [Instrumentation.AWSLambda] Request release of 2.0.0, reword CHANGELOG --- .../CHANGELOG.md | 31 +++++++++---------- 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/src/OpenTelemetry.Contrib.Instrumentation.AWSLambda/CHANGELOG.md b/src/OpenTelemetry.Contrib.Instrumentation.AWSLambda/CHANGELOG.md index ba2479e0a3..dbf79fff9c 100644 --- a/src/OpenTelemetry.Contrib.Instrumentation.AWSLambda/CHANGELOG.md +++ b/src/OpenTelemetry.Contrib.Instrumentation.AWSLambda/CHANGELOG.md @@ -2,23 +2,22 @@ ## Unreleased -* Updated the `ActivitySource` name to the assembly name: - `OpenTelemetry.Instrumentation.AWSLambda` +## 2.0.0 + +* BREAKING (behavior): Update the `ActivitySource` name to not include `Contrib`. + The new activity source name is `OpenTelemetry.Instrumentation.AWSLambda`. ([#534](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/534)) -* Added public option `AWSLambdaInstrumentationOptions.DisableAwsXRayContextExtraction`. -* Extended public API of the `AWSLambdaWrapper`: added optional parent - context (`ActivityContext`) to all `Trace` methods. -* Enhanced parent extraction: if the parent context is not provided - then it can be extracted from the incoming request for certain types of the request. - If the parent is not extracted from the incoming request then it can be extracted - from the AWS X-Ray tracing header if AWS X-Ray context extraction - is not disabled (`DisableAwsXRayContextExtraction`). -* Changed behaviour of the `OnFunctionStart` method: Activity is created even - if the parent context is not defined. -* Breaking change: `AWSLambdaWrapper.Trace` overloads without `ILambdaContext` argument - have been completely removed. -* Added two new `AWSLambdaWrapper.Trace` overloads without generic input arguments. - ([#408](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/408)) +* Rewrite of parent context handling and related changes + ([#408](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/408)): + * BREAKING (API): Remove `AWSLambdaWrapper.Trace` overloads without `ILambdaContext` parameter. + * BREAKING (behavior): Add automatic parent extraction from HTTP triggers (API Gateway Proxy events), + using the configured global textmap propagator. + * BREAKING (behavior): An activity is now also created if no parent context could be extracted + (previously this package would only create activities if a valid parent span context could be extracted + with X-Ray) + * Add optional parent context (`ActivityContext`) to `AWSLambdaWrapper.Trace`. + * Add `AWSLambdaInstrumentationOptions.DisableAwsXRayContextExtraction` initialization option. + * Add `AWSLambdaWrapper.Trace` overloads without generic input arguments. ## 1.1.0-beta1 From 2aac8b991a601cdc46af5cf605b0a4cf3842b13b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20Neum=C3=BCller?= Date: Wed, 17 Aug 2022 17:52:08 +0200 Subject: [PATCH 2/8] mdlint line length. --- .../CHANGELOG.md | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/src/OpenTelemetry.Contrib.Instrumentation.AWSLambda/CHANGELOG.md b/src/OpenTelemetry.Contrib.Instrumentation.AWSLambda/CHANGELOG.md index dbf79fff9c..4eacec6717 100644 --- a/src/OpenTelemetry.Contrib.Instrumentation.AWSLambda/CHANGELOG.md +++ b/src/OpenTelemetry.Contrib.Instrumentation.AWSLambda/CHANGELOG.md @@ -5,18 +5,20 @@ ## 2.0.0 * BREAKING (behavior): Update the `ActivitySource` name to not include `Contrib`. - The new activity source name is `OpenTelemetry.Instrumentation.AWSLambda`. + The new activity source name is `OpenTelemetry.Instrumentation.AWSLambda` ([#534](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/534)) * Rewrite of parent context handling and related changes ([#408](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/408)): - * BREAKING (API): Remove `AWSLambdaWrapper.Trace` overloads without `ILambdaContext` parameter. - * BREAKING (behavior): Add automatic parent extraction from HTTP triggers (API Gateway Proxy events), - using the configured global textmap propagator. - * BREAKING (behavior): An activity is now also created if no parent context could be extracted - (previously this package would only create activities if a valid parent span context could be extracted - with X-Ray) + * BREAKING (API): Remove `AWSLambdaWrapper.Trace` overloads + without `ILambdaContext` parameter. + * BREAKING (behavior): Add automatic parent extraction from HTTP triggers + * (API Gateway Proxy events), using the configured global textmap propagator. + * BREAKING (behavior): An activity is now also created if no parent context + could be extracted (previously this package would only create activities if + a valid parent span context could be extracted with X-Ray). * Add optional parent context (`ActivityContext`) to `AWSLambdaWrapper.Trace`. - * Add `AWSLambdaInstrumentationOptions.DisableAwsXRayContextExtraction` initialization option. + * Add `AWSLambdaInstrumentationOptions.DisableAwsXRayContextExtraction` + initialization option. * Add `AWSLambdaWrapper.Trace` overloads without generic input arguments. ## 1.1.0-beta1 From 9acd7e19726b0d6f11521451595dd92c900da388 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20Neum=C3=BCller?= Date: Wed, 24 Aug 2022 17:27:51 +0200 Subject: [PATCH 3/8] Make a beta release first. --- .../CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/OpenTelemetry.Contrib.Instrumentation.AWSLambda/CHANGELOG.md b/src/OpenTelemetry.Contrib.Instrumentation.AWSLambda/CHANGELOG.md index 4eacec6717..45465d3ab3 100644 --- a/src/OpenTelemetry.Contrib.Instrumentation.AWSLambda/CHANGELOG.md +++ b/src/OpenTelemetry.Contrib.Instrumentation.AWSLambda/CHANGELOG.md @@ -2,7 +2,7 @@ ## Unreleased -## 2.0.0 +## 2.0.0-beta1 * BREAKING (behavior): Update the `ActivitySource` name to not include `Contrib`. The new activity source name is `OpenTelemetry.Instrumentation.AWSLambda` From fbfcdfe3a6cd4d2993d1710518d964e7f4f58511 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20Neum=C3=BCller?= Date: Tue, 6 Sep 2022 11:57:41 +0200 Subject: [PATCH 4/8] Add changelog for #608. --- src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md index d6b9e4f637..4afba5d3cc 100644 --- a/src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md +++ b/src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md @@ -4,11 +4,16 @@ ## 2.0.0-beta1 +Release PR: [#590](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/590) + * BREAKING (API, behavior): Rename package to OpenTelemetry.Instrumentation.AWSLambda (remove ".Contrib") ([#593](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/593)). This also affects the `ActivitySource` name (superseding [#534](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/534)). * BREAKING (API): Move public class AWSLambdaWrapper out of Implementation subnamespace ([#593](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/593)) +* BREAKING (API): Rename overloads of `AWSLambdaWrapper.Trace` that take an async + handler to `TraceAsync`, to emphasize that they (usually) need to be awaited. + ([#608](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/608)) * Rewrite of parent context handling and related changes ([#408](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/408)): * BREAKING (API): Remove `AWSLambdaWrapper.Trace` overloads From fa5ec229f5c35bb4c4a0dbabfe0b7f8f8ce1d82e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20Neum=C3=BCller?= Date: Thu, 8 Sep 2022 11:42:21 +0200 Subject: [PATCH 5/8] Change version number. --- src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md index 4afba5d3cc..6835af7a35 100644 --- a/src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md +++ b/src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md @@ -2,10 +2,12 @@ ## Unreleased -## 2.0.0-beta1 +## 1.1.0-beta2 Release PR: [#590](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/590) +This is the first release with the new package name `OpenTelemetry.Instrumentation.AWSLambda`. + * BREAKING (API, behavior): Rename package to OpenTelemetry.Instrumentation.AWSLambda (remove ".Contrib") ([#593](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/593)). This also affects the `ActivitySource` name (superseding [#534](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/534)). From 175dbe946059f8256d7ab014897ab63e137f14c5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20Neum=C3=BCller?= Date: Mon, 12 Sep 2022 16:49:53 +0200 Subject: [PATCH 6/8] Fix typo in CHANGELOG --- src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md index c0cc546afb..db99074e9a 100644 --- a/src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md +++ b/src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md @@ -21,7 +21,7 @@ This is the first release with the new package name `OpenTelemetry.Instrumentati * BREAKING (API): Remove `AWSLambdaWrapper.Trace` overloads without `ILambdaContext` parameter. * BREAKING (behavior): Add automatic parent extraction from HTTP triggers - * (API Gateway Proxy events), using the configured global textmap propagator. + (API Gateway Proxy events), using the configured global textmap propagator. * BREAKING (behavior): An activity is now also created if no parent context could be extracted (previously this package would only create activities if a valid parent span context could be extracted with X-Ray). From 1adf550a67159cce1d6c817d10b9cbad321772c8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20Neum=C3=BCller?= Date: Mon, 12 Sep 2022 16:59:12 +0200 Subject: [PATCH 7/8] Consistent code formatting. --- src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md index db99074e9a..0295a4fe73 100644 --- a/src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md +++ b/src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md @@ -8,10 +8,10 @@ Release PR: [#590](https://github.com/open-telemetry/opentelemetry-dotnet-contri This is the first release with the new package name `OpenTelemetry.Instrumentation.AWSLambda`. -* BREAKING (API, behavior): Rename package to OpenTelemetry.Instrumentation.AWSLambda - (remove ".Contrib") ([#593](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/593)). +* BREAKING (API, behavior): Rename package to `OpenTelemetry.Instrumentation.AWSLambda` + (remove `.Contrib`) ([#593](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/593)). This also affects the `ActivitySource` name (superseding [#534](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/534)). -* BREAKING (API): Move public class AWSLambdaWrapper out of Implementation subnamespace +* BREAKING (API): Move public class `AWSLambdaWrapper` out of `Implementation` subnamespace ([#593](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/593)) * BREAKING (API): Rename overloads of `AWSLambdaWrapper.Trace` that take an async handler to `TraceAsync`, to emphasize that they (usually) need to be awaited. @@ -28,7 +28,7 @@ This is the first release with the new package name `OpenTelemetry.Instrumentati * Add optional parent context (`ActivityContext`) to `AWSLambdaWrapper.Trace`. * Add `AWSLambdaInstrumentationOptions.DisableAwsXRayContextExtraction` initialization option. -* Add version to ActivitySource ([#593](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/593)) +* Add version to `ActivitySource` ([#593](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/593)) ## 1.1.0-beta1 From d4127a9cf2fe8b29cd765a32d24bf9ddf93c55f4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20Neum=C3=BCller?= Date: Mon, 12 Sep 2022 17:02:52 +0200 Subject: [PATCH 8/8] Use `Trace`/`TraceAsync` where applicable. --- src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md b/src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md index 0295a4fe73..b8623e83f8 100644 --- a/src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md +++ b/src/OpenTelemetry.Instrumentation.AWSLambda/CHANGELOG.md @@ -18,14 +18,14 @@ This is the first release with the new package name `OpenTelemetry.Instrumentati ([#608](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/608)) * Rewrite of parent context handling and related changes ([#408](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/408)): - * BREAKING (API): Remove `AWSLambdaWrapper.Trace` overloads + * BREAKING (API): Remove `AWSLambdaWrapper.Trace`/`TraceAsync` overloads without `ILambdaContext` parameter. * BREAKING (behavior): Add automatic parent extraction from HTTP triggers (API Gateway Proxy events), using the configured global textmap propagator. * BREAKING (behavior): An activity is now also created if no parent context could be extracted (previously this package would only create activities if a valid parent span context could be extracted with X-Ray). - * Add optional parent context (`ActivityContext`) to `AWSLambdaWrapper.Trace`. + * Add optional parent context (`ActivityContext`) to `AWSLambdaWrapper.Trace`/`TraceAsync`. * Add `AWSLambdaInstrumentationOptions.DisableAwsXRayContextExtraction` initialization option. * Add version to `ActivitySource` ([#593](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/593))