Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GenevaExporter] Add ability to export Log Exception using StackTrace #2422

Merged
merged 13 commits into from
Dec 18, 2024

Conversation

cijothomas
Copy link
Member

@cijothomas cijothomas commented Dec 15, 2024

Changes

Adds a new option to use StackTrace property of Exception be used while exporting Logs.
Fixes #2421

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch changed the title [GenevaExporter] - Add ability to export Log Exception using StackTrace [GenevaExporter] Add ability to export Log Exception using StackTrace Dec 17, 2024
@github-actions github-actions bot requested a review from CodeBlanch December 17, 2024 19:57
@CodeBlanch CodeBlanch merged commit ab278bb into open-telemetry:main Dec 18, 2024
65 checks passed
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (71655ce) to head (3cc969b).
Report is 662 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #2422       +/-   ##
==========================================
- Coverage   73.91%       0   -73.92%     
==========================================
  Files         267       0      -267     
  Lines        9615       0     -9615     
==========================================
- Hits         7107       0     -7107     
+ Misses       2508       0     -2508     

see 263 files with indirect coverage changes

@cijothomas cijothomas deleted the cijothomas/ex-stacktrace branch December 18, 2024 20:13
@reyang
Copy link
Member

reyang commented Dec 20, 2024

I don't understand the direction here, if this is what we want to give to the user, what's the plan for other exporters (e.g. OTLP)?

@cijothomas
Copy link
Member Author

I don't understand the direction here, if this is what we want to give to the user, what's the plan for other exporters (e.g. OTLP)?

Otel SDK has to offer mechanism to let user pick how they want stack trace represented.
Activity in runtime already offer mechanism to let user decide this. ILogger does not, but the change would likely be in Otel SDK/Exporter, as ILogger hands the Exception object itself to the providers.

@reyang
Copy link
Member

reyang commented Dec 20, 2024

I don't understand the direction here, if this is what we want to give to the user, what's the plan for other exporters (e.g. OTLP)?

Otel SDK has to offer mechanism to let user pick how they want stack trace represented. Activity in runtime already offer mechanism to let user decide this. ILogger does not, but the change would likely be in Otel SDK/Exporter, as ILogger hands the Exception object itself to the providers.

Is there a tracking issue and design discussions? My concern is around the lack of overall design/thinking. I don't see why we want to rush here.

@cijothomas
Copy link
Member Author

I don't understand the direction here, if this is what we want to give to the user, what's the plan for other exporters (e.g. OTLP)?

Otel SDK has to offer mechanism to let user pick how they want stack trace represented. Activity in runtime already offer mechanism to let user decide this. ILogger does not, but the change would likely be in Otel SDK/Exporter, as ILogger hands the Exception object itself to the providers.

Is there a tracking issue and design discussions? My concern is around the lack of overall design/thinking. I don't see why we want to rush here.

Nothing open in Otel .NET repo, but spec has seen asks before on having the ability to control the strackTrace representation:
open-telemetry/opentelemetry-specification#2839

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Exporter.Geneva] Allow to export only stack trace in logs
4 participants