-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GenevaExporter] Add ability to export Log Exception using StackTrace #2422
[GenevaExporter] Add ability to export Log Exception using StackTrace #2422
Conversation
Co-authored-by: Rajkumar Rangaraj <[email protected]>
Co-authored-by: Rajkumar Rangaraj <[email protected]>
src/OpenTelemetry.Exporter.Geneva/Internal/MsgPack/MsgPackLogExporter.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2422 +/- ##
==========================================
- Coverage 73.91% 0 -73.92%
==========================================
Files 267 0 -267
Lines 9615 0 -9615
==========================================
- Hits 7107 0 -7107
+ Misses 2508 0 -2508 |
I don't understand the direction here, if this is what we want to give to the user, what's the plan for other exporters (e.g. OTLP)? |
Otel SDK has to offer mechanism to let user pick how they want stack trace represented. |
Is there a tracking issue and design discussions? My concern is around the lack of overall design/thinking. I don't see why we want to rush here. |
Nothing open in Otel .NET repo, but spec has seen asks before on having the ability to control the strackTrace representation: |
Changes
Adds a new option to use
StackTrace
property of Exception be used while exporting Logs.Fixes #2421
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes