Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide .NET Runtime instrumentation libraries #204

Closed
reyang opened this issue Feb 8, 2022 · 5 comments
Closed

Provide .NET Runtime instrumentation libraries #204

reyang opened this issue Feb 8, 2022 · 5 comments

Comments

@reyang
Copy link
Member

reyang commented Feb 8, 2022

Feature Request

.NET has several runtime metrics exposed via EventCounters https://github.com/dotnet/runtime/blob/main/src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/RuntimeEventSource.cs.

In the near future it is impossible for .NET runtime to completely switch over to the Meter API since these APIs are not backported to old versions of runtime.

Describe the solution you'd like:

The ask here is to provide an instrumentation library which exposes runtime metrics via Meter API, so users who need these could leverage them without having to use EventCounter wrappers.

Describe alternatives you've considered.

Leveraging something like #177 or having the users implementing the Meter/Instrument by themselves.

Leveraging the EventCounter listener/adapter has lots of problems with the scheduling - EventCounters would require the user to configure the polling schedule, which makes it less efficient for pull exporters (e.g. Prometheus), and hard to manage for push exporters (e.g. if OTLP exporter is exporting every 10 seconds, what's the proper polling period for EventCounters?)

@twenzel
Copy link
Contributor

twenzel commented Feb 14, 2022

I would like to contribute to this issue. I'll try to create a PR in the next days.

@steinarox
Copy link

Nice to see i am not the only one that looks for this 😎
For UX i like the prometheus-net instrumentation where you can add all or some groups of "default" metrics

@omamoo
Copy link

omamoo commented Feb 23, 2022

@reyang Thanks for the sharing with this feature request, It will be useful so much to add such kind of instrumentation.

@twenzel
Copy link
Contributor

twenzel commented Mar 9, 2022

@reyang Can this be closed?

@reyang
Copy link
Member Author

reyang commented Mar 9, 2022

@twenzel it's not 100% done but I think YES we should close it and iterate on your contributions. Thank you @twenzel for leading this effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants