[Instrumentation.StackExchangeRedis] Support when IConnectionMultiplexer is added with keyed service #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
comp:instrumentation.stackexchangeredis
Kielek
changed the title
Kielek
reviewed
Jun 13, 2024
src/OpenTelemetry.Instrumentation.StackExchangeRedis/CHANGELOG.md
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Instrumentation.StackExchangeRedis/.publicApi/net8.0/PublicAPI.Unshipped.txt
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Instrumentation.StackExchangeRedis/TracerProviderBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
...y.Instrumentation.StackExchangeRedis/OpenTelemetry.Instrumentation.StackExchangeRedis.csproj
Outdated
Show resolved
Hide resolved
...ation.StackExchangeRedis.Tests/OpenTelemetry.Instrumentation.StackExchangeRedis.Tests.csproj
Outdated
Show resolved
Hide resolved
|
@eerhardt, please check this PR, you were reviewing the first version. |
Kielek
reviewed
Jun 13, 2024
...y.Instrumentation.StackExchangeRedis/OpenTelemetry.Instrumentation.StackExchangeRedis.csproj
Outdated
Show resolved
Hide resolved
eerhardt
approved these changes
Jun 20, 2024
Comment on lines
+52
to
+69
| public static TracerProviderBuilder AddRedisInstrumentation( | ||
| this TracerProviderBuilder builder, | ||
| object serviceKey) | ||
| { | ||
| Guard.ThrowIfNull(serviceKey); | ||
|
|
||
| return AddRedisInstrumentation(builder, name: null, connection: null, serviceKey, configure: null); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Enables automatic data collection of outgoing requests to Redis. | ||
| /// </summary> | ||
| /// <param name="builder"><see cref="TracerProviderBuilder"/> being configured.</param> | ||
| /// <param name="name">Optional name which is used when retrieving options.</param> | ||
| /// <param name="serviceKey">Optional service key used to retrieve the <see cref="IConnectionMultiplexer"/> to instrument from the <see cref="IServiceProvider" />.</param> | ||
| /// <param name="configure">Callback to configure options.</param> | ||
| /// <returns>The instance of <see cref="TracerProviderBuilder"/> to chain the calls.</returns> | ||
| public static TracerProviderBuilder AddRedisInstrumentation( |
There was a problem hiding this comment.
Do these new overloads have tests covering them?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1885 +/- ##
==========================================
- Coverage 73.91% 69.92% -3.99%
==========================================
Files 267 5 -262
Lines 9615 276 -9339
==========================================
- Hits 7107 193 -6914
+ Misses 2508 83 -2425
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Kielek
approved these changes
Jun 25, 2024
CodeBlanch
reviewed
Jun 28, 2024
src/OpenTelemetry.Instrumentation.StackExchangeRedis/TracerProviderBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
…viderBuilderExtensions.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1451.
Changes
Added a new overload to AddRedisInstrumentation which gets serviceKey in input and get IConnectionMultiplexer with a keyed service.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes