-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[repo] Prepare release Exporter.Geneva-1.9.0-rc.1 #1875
[repo] Prepare release Exporter.Geneva-1.9.0-rc.1 #1875
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think that the changelogis true, see
opentelemetry-dotnet-contrib/src/OpenTelemetry.Exporter.Geneva/OpenTelemetry.Exporter.Geneva.csproj
Line 18 in 6b604c4
<PackageReference Include="OpenTelemetry" Version="$(OTelSdkVersion)" /> |
Feel free to ignore blocking when you fix/double checking
@Kielek - opentelemetry-dotnet-contrib/src/OpenTelemetry.Exporter.Geneva/Common.GenevaExporter.props Line 3 in 6b604c4
Will be working on removing this indirect dependency. |
I am going to hold on to this for now: would like to get the change added in Log Exporter to support https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry/CHANGELOG.md#190-rc1. Will send a separate PR. |
Co-authored-by: Piotr Kiełkowicz <[email protected]>
Just FYI the automation didn't run when this was merged because after #1873 it looks for "[release]" in the PR title not "[repo]". I asked @vishweshbankwar to manually push the tag. Sorry @vishweshbankwar! |
Note: This PR was opened automatically by the prepare release workflow.
Changes