Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Prepare release Exporter.Geneva-1.9.0-rc.1 #1875

Merged

Conversation

opentelemetrybot
Copy link
Collaborator

Note: This PR was opened automatically by the prepare release workflow.

Changes

  • CHANGELOG files updated for projects being released.

@opentelemetrybot opentelemetrybot added the infra Infra work - CI/CD, code coverage, linters label Jun 10, 2024
@opentelemetrybot opentelemetrybot requested a review from a team June 10, 2024 19:41
@github-actions github-actions bot requested a review from CodeBlanch June 10, 2024 19:52
Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think that the changelogis true, see

<PackageReference Include="OpenTelemetry" Version="$(OTelSdkVersion)" />

Feel free to ignore blocking when you fix/double checking

@vishweshbankwar
Copy link
Member

I do not think that the changelogis true, see

<PackageReference Include="OpenTelemetry" Version="$(OTelSdkVersion)" />

Feel free to ignore blocking when you fix/double checking

@Kielek - OtelSdkVersion actually points to OpenTelemetryCoreLatestPrereleaseVersion. See

<OTelSdkVersion>$(OpenTelemetryCoreLatestPrereleaseVersion)</OTelSdkVersion>

Will be working on removing this indirect dependency.

@vishweshbankwar
Copy link
Member

I am going to hold on to this for now: would like to get the change added in Log Exporter to support https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry/CHANGELOG.md#190-rc1. Will send a separate PR.

@github-actions github-actions bot added comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva and removed infra Infra work - CI/CD, code coverage, linters labels Jun 12, 2024
@vishweshbankwar vishweshbankwar merged commit c49a8e8 into main Jun 12, 2024
50 checks passed
@vishweshbankwar vishweshbankwar deleted the release/prepare-Exporter.Geneva-1.9.0-rc.1-release branch June 12, 2024 18:38
@CodeBlanch
Copy link
Member

Just FYI the automation didn't run when this was merged because after #1873 it looks for "[release]" in the PR title not "[repo]". I asked @vishweshbankwar to manually push the tag. Sorry @vishweshbankwar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants