Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Release automation improvements #1866

Merged

Conversation

CodeBlanch
Copy link
Member

Relates to open-telemetry/opentelemetry-dotnet#5657

Changes

  • Sets up the release automation to use OpenTelemetryBot
  • Refactors post-release PackageValidationBaselineVersion PR update job from package workflow into a new workflow triggered by the release publish

Details

This PR syncs up contrib with the main repo such that the release automation uses OpenTelemetryBot.

Test runs:

@CodeBlanch CodeBlanch added the infra Infra work - CI/CD, code coverage, linters label Jun 5, 2024
@CodeBlanch CodeBlanch requested a review from a team June 5, 2024 06:35
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.09%. Comparing base (71655ce) to head (4a52e09).
Report is 291 commits behind head on main.

Current head 4a52e09 differs from pull request most recent head a4949a7

Please upload reports for the commit a4949a7 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1866      +/-   ##
==========================================
- Coverage   73.91%   70.09%   -3.82%     
==========================================
  Files         267      296      +29     
  Lines        9615    10849    +1234     
==========================================
+ Hits         7107     7605     +498     
- Misses       2508     3244     +736     
Flag Coverage Δ
unittests-Exporter.Geneva 52.08% <ø> (?)
unittests-Exporter.InfluxDB 95.88% <ø> (?)
unittests-Exporter.Instana 68.22% <ø> (?)
unittests-Exporter.OneCollector 89.46% <ø> (?)
unittests-Exporter.Stackdriver 75.73% <ø> (?)
unittests-Extensions 79.83% <ø> (?)
unittests-Extensions.AWS 83.41% <ø> (?)
unittests-Extensions.Enrichment 100.00% <ø> (?)
unittests-Instrumentation.AWS 80.30% <ø> (?)
unittests-Instrumentation.AWSLambda 87.96% <ø> (?)
unittests-Instrumentation.AspNet 74.55% <ø> (?)
unittests-Instrumentation.AspNetCore 85.27% <ø> (?)
unittests-Instrumentation.ElasticsearchClient 79.87% <ø> (?)
unittests-Instrumentation.EntityFrameworkCore 55.49% <ø> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.GrpcNetClient 79.61% <ø> (?)
unittests-Instrumentation.Hangfire 93.58% <ø> (?)
unittests-Instrumentation.Http 81.08% <ø> (?)
unittests-Instrumentation.Owin 83.43% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Quartz 78.94% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.SqlClient 91.89% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 71.00% <ø> (?)
unittests-Instrumentation.Wcf 48.91% <ø> (?)
unittests-PersistentStorage 65.44% <ø> (?)
unittests-Resources.AWS 75.27% <ø> (?)
unittests-Resources.Azure 78.35% <ø> (?)
unittests-Resources.Container 72.41% <ø> (?)
unittests-Resources.Gcp 72.54% <ø> (?)
unittests-Resources.Host 51.16% <ø> (?)
unittests-Resources.Process 81.81% <ø> (?)
unittests-Resources.ProcessRuntime 72.91% <ø> (?)
unittests-Sampler.AWS 87.97% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 311 files with indirect coverage changes

Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kielek
Copy link
Contributor

Kielek commented Jun 6, 2024

Question related to the release-PRs:
Should PRs be tagged by the infra label? I think that it will be better to put there label related to the releasing artifacts. There is even a logic for tagging issues: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/4ee07f40efc5438816b718549fc99b6a0cdc3e1b/build/scripts/add-labels.ps1

@CodeBlanch
Copy link
Member Author

Question related to the release-PRs: Should PRs be tagged by the infra label? I think that it will be better to put there label related to the releasing artifacts. There is even a logic for tagging issues: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/4ee07f40efc5438816b718549fc99b6a0cdc3e1b/build/scripts/add-labels.ps1

@Kielek I like it! I'll do as a follow-up.

@CodeBlanch CodeBlanch merged commit 7c62f50 into open-telemetry:main Jun 6, 2024
264 of 265 checks passed
@CodeBlanch CodeBlanch deleted the repo-release-automation branch June 6, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants