Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Switch core-version-update workflow to use a dedicated bot account #1852

Merged

Conversation

CodeBlanch
Copy link
Member

Changes

  • Use a dedicated bot account for the core-version-update.yml workflow

Details

Relates to open-telemetry/opentelemetry-dotnet#5657

Previously we were using the github-actions bot with workflow permissions. However things done in that context (push, create pr, publish release, etc.) don't trigger other workflows. So the PRs which are opened won't have CI run for example. The recommendation (see: open-telemetry/community#2127 (comment)) was to use OpenTelemetryBot instead which is more or less a normal account.

Demo PR: CodeBlanchOrg#3

Note: That demo shows CodeBlanchBot because it is my test org but when run here it will be OpenTelemetryBot.

@CodeBlanch CodeBlanch added the infra Infra work - CI/CD, code coverage, linters label May 31, 2024
@CodeBlanch CodeBlanch requested a review from a team May 31, 2024 04:37
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.20%. Comparing base (71655ce) to head (fd69b21).
Report is 280 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1852      +/-   ##
==========================================
- Coverage   73.91%   70.20%   -3.72%     
==========================================
  Files         267      295      +28     
  Lines        9615    10826    +1211     
==========================================
+ Hits         7107     7600     +493     
- Misses       2508     3226     +718     
Flag Coverage Δ
unittests-Exporter.Geneva 52.08% <ø> (?)
unittests-Exporter.InfluxDB 94.65% <ø> (?)
unittests-Exporter.Instana 68.22% <ø> (?)
unittests-Exporter.OneCollector 89.72% <ø> (?)
unittests-Exporter.Stackdriver 75.73% <ø> (?)
unittests-Extensions 79.33% <ø> (?)
unittests-Extensions.AWS 83.41% <ø> (?)
unittests-Extensions.Enrichment 100.00% <ø> (?)
unittests-Instrumentation.AWS 87.37% <ø> (?)
unittests-Instrumentation.AWSLambda 87.96% <ø> (?)
unittests-Instrumentation.AspNet 74.55% <ø> (?)
unittests-Instrumentation.AspNetCore 85.27% <ø> (?)
unittests-Instrumentation.ElasticsearchClient 79.87% <ø> (?)
unittests-Instrumentation.EntityFrameworkCore 55.49% <ø> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.GrpcNetClient 79.61% <ø> (?)
unittests-Instrumentation.Hangfire 93.58% <ø> (?)
unittests-Instrumentation.Http 81.08% <ø> (?)
unittests-Instrumentation.Owin 83.43% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Quartz 78.94% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.SqlClient 91.89% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 68.02% <ø> (?)
unittests-Instrumentation.Wcf 48.91% <ø> (?)
unittests-PersistentStorage 65.44% <ø> (?)
unittests-ResourceDetectors.Container 75.00% <ø> (?)
unittests-Resources.AWS 76.02% <ø> (?)
unittests-Resources.Azure 77.94% <ø> (?)
unittests-Resources.Gcp 72.54% <ø> (?)
unittests-Resources.Host 51.16% <ø> (?)
unittests-Resources.Process 81.81% <ø> (?)
unittests-Resources.ProcessRuntime 82.35% <ø> (?)
unittests-Sampler.AWS 87.97% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 304 files with indirect coverage changes

@Kielek Kielek merged commit 36d4698 into open-telemetry:main Jun 3, 2024
264 of 265 checks passed
@CodeBlanch CodeBlanch deleted the core-version-update-automation branch June 3, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants