Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic convention package should be used by libraries #1847

Open
thompson-tomo opened this issue May 28, 2024 · 4 comments
Open

Semantic convention package should be used by libraries #1847

thompson-tomo opened this issue May 28, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@thompson-tomo
Copy link

Component

None

Is your feature request related to a problem?

Duplicated code

What is the expected behavior?

That no projects redefine semantic convention strings & instead they leverage the appropriate package.

Note it needs to be determined how deprecation are handled as otherwise we could end up with breaking changes

Which alternative solutions or features have you considered?

Allow the duplication and effectively have very little use for the conventions package

Additional context

No response

@thompson-tomo thompson-tomo added the enhancement New feature or request label May 28, 2024
@thompson-tomo
Copy link
Author

My proposal for discontinuation would be to use the obselete attribute & potentially make our our own attributes for experimental/opt-in which generate build info/warnings etc

@martinjt
Copy link
Member

martinjt commented Jun 1, 2024

There's an ongoing project for generating the Semantic convention packages. There's lots of implications of Obsolete, duplicates, and how package versions works across multiple languages, which is why it's taking a while.

When we have moved to that, we'll be looking at whether we should use the package in our instrumentations.

@CodeBlanch
Copy link
Member

potentially make our our own attributes for experimental/opt-in which generate build info/warnings

Just FYI .NET 8 added ExperimentalAttribute.

@thompson-tomo
Copy link
Author

yeap i noticed in one of my recent projects, so that would certainly be useful we just need to establish a way for the class generator to populate the correct attributes on the properties to ensure it is a maintainable process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants