Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SetDbStatement should be available when compiling against netstandard2.0 #1784

Open
ghost opened this issue Mar 2, 2021 · 1 comment
Open

SetDbStatement should be available when compiling against netstandard2.0 #1784

ghost opened this issue Mar 2, 2021 · 1 comment
Labels
bug Something isn't working comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient

Comments

@ghost
Copy link

ghost commented Mar 2, 2021 •
edited by ghost
Loading

Bug Report

  • OpenTelemetry Version="1.0.1"
  • OpenTelemetry.Exporter.Console Version="1.0.1"
  • OpenTelemetry.Instrumentation.SqlClient Version="1.0.0-rc2"

netstandard library imports above packages and that library is then used in a net48 project

Symptom

A clear and concise description of what the bug is.

What is the expected behavior?

SetDbStatementForStoredProcedure, SetDbStatementForText and SetDbStatement settings settable and they take effect depending on the actual runtime platform.

What is the actual behavior?

SetDbStatementForStoredProcedure, SetDbStatementForText are settable but lead to a method not found exception.
SetDbStatement is not there.

Reproduce

OTELRepo.zip

Run ConsoleApp2 in attached solution. You will get method not found exception.
@mbakalov
Copy link

mbakalov commented Mar 2, 2021

Hi @roederja2 - thanks for the repro! Will take a look.

@vishweshbankwar vishweshbankwar transferred this issue from open-telemetry/opentelemetry-dotnet May 14, 2024
@Kielek Kielek added the comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make SQL settings available unconditionally roederja/opentelemetry-dotnet
3 participants
@ghost @Kielek @mbakalov