Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity from SQL instrumentation replaces Activity.Current from the call site #1771

Closed
pardahlman opened this issue Dec 7, 2022 · 3 comments
Labels
bug Something isn't working comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient

Comments

@pardahlman
Copy link

Bug Report

List of all OpenTelemetry NuGetpackages and version that you are using:

  • OpenTelemetry.Instrumentation.SqlClient 1.0.0-rc9.9

Runtime version:

  • net6.0

Symptom

After executing an SQL command, Activity.Current is replaced by OpenTelemetry.Instrumentation.SqlClient.Execute.

What is the expected behavior?

I expect Activity.Current to be reset to the value it had before the SQL command is executed.

What is the actual behavior?

Activity.Current is replaced by OpenTelemetry.Instrumentation.SqlClient.Execute

Reproduce

See self-contained project: https://github.com/pardahlman/otel-repro

@pardahlman pardahlman added the bug Something isn't working label Dec 7, 2022
@tbajkacz
Copy link

I'm experiencing a similar issue using the OpenTelemetry.Instrumentation.EntityFrameworkCore 1.0.0-beta.3 package

@CaffeineDaemon
Copy link

I am using OpenTelemetry.Instrumentation.SqlClient 1.0.0-rc9.10 and OpenTelemetry.Instrumentation.EntityFrameworkCore 1.0.0-beta2 and had the same issue, but removing only the EntityFrameworkCore Instrumentation package solved it, so i would assume the issue comes from this package and not from the SQL client instrumentation.

@vishweshbankwar vishweshbankwar transferred this issue from open-telemetry/opentelemetry-dotnet May 14, 2024
@Kielek Kielek added the comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient label May 17, 2024
@martinjt
Copy link
Member

martinjt commented Jun 2, 2024

I've tested this and I'm not seeing this issue. Given the issue is over a year old, I suspect something has resolved this.

@martinjt martinjt closed this as not planned Won't fix, can't repro, duplicate, stale Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient
Projects
None yet
Development

No branches or pull requests

5 participants