Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some attributes are missing in the released version compared to the ones in the in repo. #1714

Open
1 of 2 tasks
AsakerMohd opened this issue May 10, 2024 · 5 comments
Open
1 of 2 tasks
Labels
comp:semanticconventions Things related to OpenTelemetry.SemanticConventions

Comments

@AsakerMohd
Copy link
Contributor

Issue with OpenTelemetry.SemanticConventions

List of all OpenTelemetry NuGet
packages
and version that you are
using (e.g. OpenTelemetry 1.3.2):

    <PackageReference Include="OpenTelemetry" Version="1.8.1" />
    <PackageReference Include="OpenTelemetry.Api" Version="1.8.1" />
    <PackageReference Include="OpenTelemetry.Contrib.Extensions.AWSXRay" Version="1.2.0" />
    <PackageReference Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="1.8.1" />
    <PackageReference Include="OpenTelemetry.SemanticConventions" Version="1.0.0-rc9.9" />

Runtime version (e.g. net462, net48, net6.0, net7.0 etc. You can
find this information from the *.csproj file):

  • net8.0

Is this a feature request or a bug?

  • Feature Request
  • Bug

What is the expected behavior?

  1. The released version of OpenTelemetry.SemanticConventions should include all the semantic conventions that are available in the contrib repo. For example, AttributeServiceName is not available in the released package.

  2. Another bug, I tried running dotnet add package OpenTelemetry.SemanticConventions --prerelease to pull SemanticConventions but that didn't work. I had to manually set the version to 1.0.0-rc9.9 to be able to pull it according to versions available in https://api.nuget.org/v3/registration5-gz-semver2/opentelemetry.semanticconventions/index.json. Looks like the date that package was released is 04/16, so before moving OpenTelemetry.SemanticConventions to Conbrib.

What is the actual behavior?

  1. Attributes like AttributeServiceName and others are not available.

  2. OpenTelemetry.SemanticConventions using --prelease flag is not working.

dotnet add package OpenTelemetry.SemanticConventions --prerelease
  Determining projects to restore...
  Writing /var/folders/w1/kp4yfvc562q8r4hmvcpwh_gh0000gs/T/tmp29Ke6X.tmp
info : X.509 certificate chain validation will use the fallback certificate bundle at '/usr/local/share/dotnet/sdk/8.0.204/trustedroots/codesignctl.pem'.
info : X.509 certificate chain validation will use the fallback certificate bundle at '/usr/local/share/dotnet/sdk/8.0.204/trustedroots/timestampctl.pem'.
info : Adding PackageReference for package 'OpenTelemetry.SemanticConventions' into project '/Volumes/workplace/otel/aws-otel-dotnet-instrumentation/src/AWS.OpenTelemetry.AutoInstrumentation/AWS.OpenTelemetry.AutoInstrumentation.csproj'.
info :   CACHE https://api.nuget.org/v3/registration5-gz-semver2/opentelemetry.semanticconventions/index.json
error: There are no versions available for the package 'OpenTelemetry.SemanticConventions'.

Additional Context

Add any other context about the feature request here.

@AsakerMohd AsakerMohd added the comp:semanticconventions Things related to OpenTelemetry.SemanticConventions label May 10, 2024
@AsakerMohd
Copy link
Contributor Author

Are there any other information required from my side for this?

@Kielek
Copy link
Contributor

Kielek commented May 15, 2024

@AsakerMohd, the package was previously released from the main repository. There were a decision to unlist it from nuget.org so that it cannot be found by nuget package manager, but can be manually added to the project. It is the reason why dotnet add package OpenTelemetry.SemanticConventions --prerelease command is not working.

@joegoldman2 started working on bringing it here again in #1672. This PR contains a lot of good stuff, but IMO it is not ready to be released. We should consider the way how we can have backward compatibility between releases. One of the idea is to include sem.conv. version in the namespaces and adding files incrementally.

@joegoldman2, what is your plan on this package?

@joegoldman2
Copy link
Contributor

No plan for the moment. I'm ready to help but I would need some insights about the next steps and what should be done.

@joegoldman2
Copy link
Contributor

Is there a need to support several versions of Semantic Conventions in parallel? If not, why not version the package with the same version number as Semantic Conventions (1.25, 1.26, etc)?

@Kielek
Copy link
Contributor

Kielek commented May 22, 2024

It is going about backward compatibility. Historically, semantic conventions removed part of the attributes (instead of marking them as deprecated). We are not allowed to remove any attributes from the package without bumping major version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:semanticconventions Things related to OpenTelemetry.SemanticConventions
Projects
None yet
Development

No branches or pull requests

3 participants