-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some attributes are missing in the released version compared to the ones in the in repo. #1714
Comments
Are there any other information required from my side for this? |
@AsakerMohd, the package was previously released from the main repository. There were a decision to unlist it from nuget.org so that it cannot be found by nuget package manager, but can be manually added to the project. It is the reason why @joegoldman2 started working on bringing it here again in #1672. This PR contains a lot of good stuff, but IMO it is not ready to be released. We should consider the way how we can have backward compatibility between releases. One of the idea is to include sem.conv. version in the namespaces and adding files incrementally. @joegoldman2, what is your plan on this package? |
No plan for the moment. I'm ready to help but I would need some insights about the next steps and what should be done. |
Is there a need to support several versions of Semantic Conventions in parallel? If not, why not version the package with the same version number as Semantic Conventions (1.25, 1.26, etc)? |
It is going about backward compatibility. Historically, semantic conventions removed part of the attributes (instead of marking them as deprecated). We are not allowed to remove any attributes from the package without bumping major version. |
Issue with OpenTelemetry.SemanticConventions
List of all OpenTelemetry NuGet
packages and version that you are
using (e.g.
OpenTelemetry 1.3.2
):Runtime version (e.g.
net462
,net48
,net6.0
,net7.0
etc. You canfind this information from the
*.csproj
file):Is this a feature request or a bug?
What is the expected behavior?
The released version of OpenTelemetry.SemanticConventions should include all the semantic conventions that are available in the contrib repo. For example, AttributeServiceName is not available in the released package.
Another bug, I tried running
dotnet add package OpenTelemetry.SemanticConventions --prerelease
to pull SemanticConventions but that didn't work. I had to manually set the version to1.0.0-rc9.9
to be able to pull it according to versions available in https://api.nuget.org/v3/registration5-gz-semver2/opentelemetry.semanticconventions/index.json. Looks like the date that package was released is 04/16, so before moving OpenTelemetry.SemanticConventions to Conbrib.What is the actual behavior?
Attributes like AttributeServiceName and others are not available.
OpenTelemetry.SemanticConventions using --prelease flag is not working.
Additional Context
Add any other context about the feature request here.
The text was updated successfully, but these errors were encountered: