-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[productcatalogservice]add basic metric support #674
[productcatalogservice]add basic metric support #674
Conversation
docs/services/productcatalogservice.md should also be updated. |
|
1f77387
to
be01edc
Compare
@fatsheep9146 @julianocosta89 please review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to update the golang version and the go get
command in order to be able to build the new container.
LGTM
* add basic metric support * fix lint * fix lint * fix lint * Update productcatalogservice.md * Update Dockerfile Co-authored-by: Ziqi Zhao <[email protected]> Co-authored-by: Juliano Costa <[email protected]> Co-authored-by: Juliano Costa <[email protected]>
Changes
add basic metric support
related:#66
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.md
updated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.