-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OTel java agent with JMX Metric Insights to kafka #654
Conversation
Signed-off-by: svrnm <[email protected]>
Signed-off-by: svrnm <[email protected]>
Signed-off-by: svrnm <[email protected]>
Signed-off-by: svrnm <[email protected]>
Signed-off-by: svrnm <[email protected]>
Signed-off-by: svrnm <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Runs fine. Nice to get the additional Kafka metrics. Kafka seems to consume a massive amount of memory, but I guess there's no easy solution for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic. TYVM!
…#654) * Add otel agent with JMX metric insights to kafka Signed-off-by: svrnm <[email protected]> * Increase memory limit for kafka * Remove pb files Signed-off-by: svrnm <[email protected]> * Add docs for kafka service Signed-off-by: svrnm <[email protected]> * Revert removal of demo.proto Signed-off-by: svrnm <[email protected]> * Update CHANGELOG Signed-off-by: svrnm <[email protected]> * Fix markdownlint error Signed-off-by: svrnm <[email protected]> Signed-off-by: svrnm <[email protected]> Co-authored-by: Carter Socha <[email protected]> Co-authored-by: Pierre Tessier <[email protected]>
Changes
This PR adds the java agent to the kafka broker. While this will not provide tracing, it will use JMX Metric Insights generate metrics and export them to prometheus:
Additional info
We plan to have a blog post about JMX Metric Insights on opentelemetry.io eventually, so calling out that the demo is making use of it would be a nice feature:-)
Merge Requirements
CHANGELOG.md
updated to document new feature additions