feature(frontend): adding synthetic attribute flag to FE instrumentation #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
2 tasks
puckpuck
requested changes
Dec 14, 2022
puckpuck
requested changes
Dec 15, 2022
fatsheep9146
approved these changes
Dec 20, 2022
puckpuck
approved these changes
Dec 24, 2022
|
@xoscar I know it's the holidays so you may not get this, but when you get a chance please update the branch so we can get this one merged. In the future, if you do a PR from your personal fork instead of an organizational one, we can update the branch for you. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
@puckpuck makes sense! I'll start doing that, thanks for the feedback! 😄 |
3 tasks
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
…ion (open-telemetry#631) * feature(frontend): adding synthetic attribute flag to FE instrumentation * feature(frontend): adding frontend documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR includes a new span attribute coming from the FE instrumentation when triggering a fetch request to the API endpoints.
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.