set memory limits for all services #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinlparker
approved these changes
Oct 18, 2022
|
feature-flag-service limit of 160M is too strict and causes the container to be Killed in my docker compose deploy. It may be environment specific, but a minimum limit I can get this working is 1600M. |
@styblope 1600M is definitely not normal. Which OS is this on? |
|
I know, it's weird, but I stepped up piece by piece until the container stopped getting killed. It's on x86_64 Fedora 34 VM (vsphere), 8GB RAM, Docker CE 20.10.17. Maybe it's a docker thing? Or a startup ram hike. |
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
* set limits for all services * memory limit for services * re-add quoteservice to frontend dependency * Update docker-compose.yml Co-authored-by: Austin Parker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Sets reasonable memory limits for all services, based on an 80% memory target for each service, running the app for 7 days (minimum of 20M).
Data used by this PR incorporated the memory limits shown in the chart above which is a 7-day run on EKS. Some exceptions for loadgenerator, email, and quote services where I used data from docker stats after running the app on my local machine for several days.
CHANGELOG.mdupdated for non-trivial changes