Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cartservice] GetCart should be async? #372

Merged
merged 2 commits into from
Sep 23, 2022

Conversation

cartermp
Copy link
Contributor

The code used .Result, which blocks the current thread rather than allowing it to await a result. Since the interface returns a Task<Cart> I think this was probably just an omission.

@cartermp cartermp requested a review from a team September 17, 2022 19:07
@cartersocha
Copy link
Contributor

@mic-max, @cijothomas

Copy link
Contributor

@cartersocha cartersocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this @cartermp

@cartersocha cartersocha merged commit 0cbf181 into open-telemetry:main Sep 23, 2022
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants