Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and enhance metric support for product catalog service (Go) #66

Closed
6 tasks
cartersocha opened this issue May 30, 2022 · 6 comments
Closed
6 tasks
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@cartersocha
Copy link
Contributor

The following are requirements for metrics in the project. Not all services will meet all requirements.

  • Service metrics should not be duplicative of trace-derived metrics.
  • Services should emit multiple business metrics where appropriate.
  • Services should emit trace exemplars for their metrics.
  • Services should use push metrics where possible.
  • Services should explicitly read baggage where needed.
  • Collectors should perform metric transforms to normalize resource and service metrics.

Referencing issue: #43

@Frapschen
Copy link
Contributor

hi,I want help it. :)

@cartersocha
Copy link
Contributor Author

All yours! @Frapschen

@Frapschen
Copy link
Contributor

@cartersocha I'm a little confuse, what metrics should we add to service? in my view, we can add some span metric by the otel-collector:

  • calls_total
  • latency_bucket

@cartersocha
Copy link
Contributor Author

We haven’t had time to define our metric story yet. We are planning on discussing overall metric requirements in our next sig meeting.

We’ll need to set up a consumption experience too. I’m guessing we’ll add grafana in a container or something similar.

Feel free to open a pr with what metrics you think would be useful. Then we can use that to solicit feedback / input from everyone

@Frapschen
Copy link
Contributor

The newest implementation instrumentation for the runtime package is in process, waiting for its finish.

@austinlparker
Copy link
Member

Basic metrics have been added; closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants