-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review and enhance metric support for product catalog service (Go) #66
Comments
hi,I want help it. :) |
All yours! @Frapschen |
@cartersocha I'm a little confuse, what metrics should we add to service? in my view, we can add some span metric by the otel-collector:
|
We haven’t had time to define our metric story yet. We are planning on discussing overall metric requirements in our next sig meeting. We’ll need to set up a consumption experience too. I’m guessing we’ll add grafana in a container or something similar. Feel free to open a pr with what metrics you think would be useful. Then we can use that to solicit feedback / input from everyone |
The newest implementation instrumentation for the |
Basic metrics have been added; closing issue. |
The following are requirements for metrics in the project. Not all services will meet all requirements.
Referencing issue: #43
The text was updated successfully, but these errors were encountered: