Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronized calls to Exporter::Export and Exporter::Shutdown. #1158

Closed
lalitb opened this issue Dec 20, 2021 · 0 comments · Fixed by #1164
Closed

Synchronized calls to Exporter::Export and Exporter::Shutdown. #1158

lalitb opened this issue Dec 20, 2021 · 0 comments · Fixed by #1164
Assignees
Labels
bug Something isn't working

Comments

@lalitb
Copy link
Member

lalitb commented Dec 20, 2021

As of now,

  1. SimpleSpanProcessor ensures that it is not possible to concurrently call Exporter::Shutdown().
  2. SimpleSpanProcessor ensures that it is not possible to concurrently call Exporter::Export()
  3. But it is still possible to call Exporter::Shutdown() and Exporter::Export() concurrently, and if that happens, is_shutdown/isShutdown variable defined in different exporters need to be protected.

opentelemetry::common::SpinLockMutex is lock-free, and one option could be to protect is_shutdown with that.

@lalitb lalitb added the bug Something isn't working label Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants