From 30d9bbc0476bd26174ef8bad56961ebcda8b436d Mon Sep 17 00:00:00 2001 From: Ehsan Saei <71217171+esigo@users.noreply.github.com> Date: Wed, 8 Dec 2021 23:51:30 +0100 Subject: [PATCH 1/2] Document dependencies (#1119) --- INSTALL.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/INSTALL.md b/INSTALL.md index 65cb66a28d..308c847b40 100644 --- a/INSTALL.md +++ b/INSTALL.md @@ -3,6 +3,10 @@ [CMake](https://cmake.org/) and [Bazel](https://bazel.build) are the official build systems for opentelemetry-cpp. +## Dependencies + +You can link OpenTelemetry C++ SDK with libraries provided in [dependencies.md](https://github.com/open-telemetry/opentelemetry-cpp/blob/main/docs/dependencies.md) (complete list of libraries with versions used in our CI can be found [here](https://github.com/open-telemetry/opentelemetry-cpp/blob/main/third_party_release)). + ## Build instructions using CMake ### Prerequisites for CMake From 5e258b0c0c192620fe3410b9e56c7480fa278a82 Mon Sep 17 00:00:00 2001 From: Tom Tan Date: Wed, 8 Dec 2021 17:02:17 -0800 Subject: [PATCH 2/2] Add explicit type conversion when assigning value_type to Jaeger tag (#1118) --- exporters/jaeger/test/jaeger_recordable_test.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/exporters/jaeger/test/jaeger_recordable_test.cc b/exporters/jaeger/test/jaeger_recordable_test.cc index 586b5f7ccf..b496db9028 100644 --- a/exporters/jaeger/test/jaeger_recordable_test.cc +++ b/exporters/jaeger/test/jaeger_recordable_test.cc @@ -168,15 +168,15 @@ void addTag(thrift::TagType::type tag_type, tag.__set_vType(tag_type); if (tag_type == thrift::TagType::LONG) { - tag.__set_vLong(value); + tag.__set_vLong(static_cast(value)); } else if (tag_type == thrift::TagType::DOUBLE) { - tag.__set_vDouble(value); + tag.__set_vDouble(static_cast(value)); } else if (tag_type == thrift::TagType::BOOL) { - tag.__set_vBool(value); + tag.__set_vBool(static_cast(value)); } tags.push_back(tag);