Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does building opentelemetry-cpp-contrib/instrumentation/nginx requires NGINX_VERSION and downloading Nginx? Can I just specify Nginx source myself? #508

Open
gregory112 opened this issue Jan 2, 2025 · 0 comments
Labels

Comments

@gregory112
Copy link

It seems that to configure it it requires NGINX_VERSION to be supplied, which will download Nginx. I intent to build Nginx from source anyway to add other modules, which means I already have Nginx source downloaded. How can I configure it to use existing Nginx source?

Steps to reproduce
cmake -DNGINX_VERSION=1.26.0

What is the expected behavior?
Can point to existing Nginx source

What is the actual behavior?
It downloads Nginx source again

@gregory112 gregory112 added the instrumentation:nginx Nginx module label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant