fix: set error status on span with 5xx status code (#443)

open-telemetry · Jun 9, 2024 · 415f182 · 415f182
1 parent 58601e5
commit 415f182
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/instrumentation/nginx/src/otel_ngx_module.cpp b/instrumentation/nginx/src/otel_ngx_module.cpp
@@ -545,7 +545,14 @@ ngx_int_t FinishNgxSpan(ngx_http_request_t* req) {
   }
 
   auto span = context->request_span;
-  span->SetAttribute("http.status_code", req->headers_out.status);
+  const auto status_code = req->headers_out.status;
+  span->SetAttribute("http.status_code", status_code);
+
+  if (status_code >= 500) {
+    span->SetStatus(trace::StatusCode::kError);
+  } else {
+    span->SetStatus(trace::StatusCode::kOk);
+  }
 
   OtelNgxLocationConf* locConf = GetOtelLocationConf(req);