Added memory ballast e2e behavior test #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
requested review from
bogdandrutu,
flands,
pjanotti,
songy23 and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
========================================
Coverage ? 71.6%
========================================
Files ? 95
Lines ? 6100
Branches ? 0
========================================
Hits ? 4368
Misses ? 1505
Partials ? 227Continue to review full report at Codecov.
|
tigrannajaryan
previously approved these changes
Jul 1, 2019
pjanotti
previously approved these changes
Jul 1, 2019
tigrannajaryan
requested changes
Jul 2, 2019
tigrannajaryan
previously approved these changes
Jul 2, 2019
tigrannajaryan
previously approved these changes
Jul 2, 2019
Added a new test that verifies that the ballast behaves only counts to virtual memory and is not actually allocated. Also added `tests/results/BASELINE.md` to act as the baseline test results file. The TESTRESULTS.md file was modified on every run and it would change in every PR from every contributor. It added additional work when one didn't want to include it in a PR which was most of the time. Only time it should be updated is when someone adds or updates a new perf test.
pjanotti
referenced
this pull request
in pjanotti/opentelemetry-service
Jul 2, 2019
- Shorter names for variables and types. - Print flag values instead of pointer values. - Use -config instead of -exporters-yaml because config contains more than exporters.
tigrannajaryan
approved these changes
Jul 2, 2019
pjanotti
approved these changes
Jul 2, 2019
6 tasks
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
* add propagation api. * add http propagator interface and w3c propagator implementation. * remove Extract api from trace. * remove Extract interface for tracer. * fix copyright. * fix variable names and comments. * move inject/extract out of trace. * replace INVALID_SPAN_CONTEXT with EmptySpanContext function. * fix tag.Map. * make carrier as interface instead of http.Request. * rename structs and update doc comments.. * add doc.go * update doc. * add noop propagator. * add new propagation api with Supplier interface. - added Default Tracer which simply propagates SpanContext. - added CopyOfRemote option to simply create remote span. * remove old propagator. * rename propagator to TextFormatPropagator. * rename default tracer/span as pass_through tracer/span. * add test for pass through tracer. * add missing interface to pass through tracer. * return SpanContext instead of contex.Context from Extract interface. - also remove PassThroughTracer * fix review comments. * add more test cases for traceContext extraction. * remove tidy temporarily from circle-ci target to avoid build failure. * allow header ending in dash '-'. * add inject test for non-zero value other than 01 for traceoption * add AddLink and Link interface to MockSpan * fix running go mod tidy on every build.
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
* Configure dependabot Also better organize Makefile
swiatekm
pushed a commit
to swiatekm/opentelemetry-collector
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new test that verifies that the ballast behaves only counts to
virtual memory and is not actually allocated.
Also added
tests/results/BASELINE.mdto act as the baseline testresults file. The TESTRESULTS.md file was modified on every run and it
would change in every PR from every contributor. It added additional
work when one didn't want to include it in a PR which was most of the
time. Only time it should be updated is when someone adds or updates a
new perf test.