Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate special Configs for each component type, use a standard opaque Config #6617

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

bogdandrutu
Copy link
Member

Updates #6578

@bogdandrutu bogdandrutu requested review from a team and codeboten November 23, 2022 19:03
@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Base: 91.06% // Head: 91.13% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (3fc208d) compared to base (bd269df).
Patch coverage: 97.61% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6617      +/-   ##
==========================================
+ Coverage   91.06%   91.13%   +0.06%     
==========================================
  Files         244      244              
  Lines       14120    14114       -6     
==========================================
+ Hits        12859    12863       +4     
+ Misses       1010     1000      -10     
  Partials      251      251              
Impacted Files Coverage Δ
component/componenttest/shutdown_verifier.go 0.00% <0.00%> (ø)
component/config.go 87.50% <ø> (+3.01%) ⬆️
config/exporter.go 100.00% <ø> (ø)
config/extension.go 100.00% <ø> (ø)
config/processor.go 100.00% <ø> (ø)
config/receiver.go 100.00% <ø> (ø)
exporter/exporterhelper/logs.go 80.64% <ø> (ø)
exporter/exporterhelper/metrics.go 80.64% <ø> (ø)
exporter/exporterhelper/traces.go 80.95% <ø> (ø)
exporter/loggingexporter/config.go 64.51% <ø> (ø)
... and 40 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great simplification!

@bogdandrutu bogdandrutu merged commit 1028e3d into open-telemetry:main Nov 23, 2022
@bogdandrutu bogdandrutu deleted the rmconfig branch November 23, 2022 23:02
jaronoff97 pushed a commit to lightstep/opentelemetry-collector that referenced this pull request Dec 14, 2022
jaronoff97 pushed a commit to lightstep/opentelemetry-collector that referenced this pull request Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants