-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[otlphttpreceiver] Allow H2C connections to otlp http receiver #10996
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Israel Blancas <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10996 +/- ##
=======================================
Coverage 91.45% 91.45%
=======================================
Files 447 447
Lines 23721 23727 +6
=======================================
+ Hits 21694 21700 +6
Misses 1653 1653
Partials 374 374 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Israel Blancas <[email protected]>
Signed-off-by: Israel Blancas <[email protected]>
@djaglowski could you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this should be opt-in, and have a log warning stating that this is a "weird" configuration. Only very specific setups have a valid reason to have this enabled, such as sidecars terminating TLS right before handing over to the main container.
Signed-off-by: Israel Blancas <[email protected]>
Can somebody from @open-telemetry/collector-approvers take a look? Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, however, I feel bad for introducing new features when we are aiming for v1.
If the Collector approvers decide that this is something we should NOT have for v1, I'd be on their side.
Description
Allow H2C connections to otlp http receiver
Fixes #10952